From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxDhg-0001I3-96 for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:48:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxDhf-0005Ft-Eu for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:48:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46020) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bxDhf-0005Fi-7d for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:48:15 -0400 From: "Daniel P. Berrange" Date: Thu, 20 Oct 2016 14:47:58 +0100 Message-Id: <1476971286-10612-3-git-send-email-berrange@redhat.com> In-Reply-To: <1476971286-10612-1-git-send-email-berrange@redhat.com> References: <1476971286-10612-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 02/10] io: Use qio_channel_has_feature() where applicable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Felipe Franciosi , "Daniel P . Berrange" From: Felipe Franciosi Parts of the code have been testing QIOChannel features directly with a logical AND. This patch makes it all consistent by using the qio_channel_has_feature() function to test if a feature is present. Signed-off-by: Felipe Franciosi Signed-off-by: Daniel P. Berrange --- io/channel-socket.c | 3 ++- io/channel-tls.c | 2 +- io/channel-websock.c | 2 +- io/channel.c | 4 ++-- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/io/channel-socket.c b/io/channel-socket.c index 6710b2e..8fc6e5a 100644 --- a/io/channel-socket.c +++ b/io/channel-socket.c @@ -403,7 +403,8 @@ static void qio_channel_socket_finalize(Object *obj) QIOChannelSocket *ioc = QIO_CHANNEL_SOCKET(obj); if (ioc->fd != -1) { - if (QIO_CHANNEL(ioc)->features & (1 << QIO_CHANNEL_FEATURE_LISTEN)) { + QIOChannel *ioc_local = QIO_CHANNEL(ioc); + if (qio_channel_has_feature(ioc_local, QIO_CHANNEL_FEATURE_LISTEN)) { Error *err = NULL; socket_listen_cleanup(ioc->fd, &err); diff --git a/io/channel-tls.c b/io/channel-tls.c index 9a8525c..f7bb0e3 100644 --- a/io/channel-tls.c +++ b/io/channel-tls.c @@ -111,7 +111,7 @@ qio_channel_tls_new_client(QIOChannel *master, ioc = QIO_CHANNEL(tioc); tioc->master = master; - if (master->features & (1 << QIO_CHANNEL_FEATURE_SHUTDOWN)) { + if (qio_channel_has_feature(master, QIO_CHANNEL_FEATURE_SHUTDOWN)) { ioc->features |= (1 << QIO_CHANNEL_FEATURE_SHUTDOWN); } object_ref(OBJECT(master)); diff --git a/io/channel-websock.c b/io/channel-websock.c index 533bd4b..75df03e 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -497,7 +497,7 @@ qio_channel_websock_new_server(QIOChannel *master) ioc = QIO_CHANNEL(wioc); wioc->master = master; - if (master->features & (1 << QIO_CHANNEL_FEATURE_SHUTDOWN)) { + if (qio_channel_has_feature(master, QIO_CHANNEL_FEATURE_SHUTDOWN)) { ioc->features |= (1 << QIO_CHANNEL_FEATURE_SHUTDOWN); } object_ref(OBJECT(master)); diff --git a/io/channel.c b/io/channel.c index 923c465..e50325c 100644 --- a/io/channel.c +++ b/io/channel.c @@ -40,7 +40,7 @@ ssize_t qio_channel_readv_full(QIOChannel *ioc, QIOChannelClass *klass = QIO_CHANNEL_GET_CLASS(ioc); if ((fds || nfds) && - !(ioc->features & (1 << QIO_CHANNEL_FEATURE_FD_PASS))) { + !qio_channel_has_feature(ioc, QIO_CHANNEL_FEATURE_FD_PASS)) { error_setg_errno(errp, EINVAL, "Channel does not support file descriptor passing"); return -1; @@ -60,7 +60,7 @@ ssize_t qio_channel_writev_full(QIOChannel *ioc, QIOChannelClass *klass = QIO_CHANNEL_GET_CLASS(ioc); if ((fds || nfds) && - !(ioc->features & (1 << QIO_CHANNEL_FEATURE_FD_PASS))) { + !qio_channel_has_feature(ioc, QIO_CHANNEL_FEATURE_FD_PASS)) { error_setg_errno(errp, EINVAL, "Channel does not support file descriptor passing"); return -1; -- 2.7.4