From: vijay.kilari@gmail.com
To: qemu-arm@nongnu.org, peter.maydell@linaro.org,
pbonzini@redhat.com, rth@twiddle.net
Cc: qemu-devel@nongnu.org, vijay.kilari@gmail.com,
Vijaya Kumar K <Vijaya.Kumar@cavium.com>
Subject: [Qemu-devel] [PATCH v3 1/3] cutils: Set __builtin_prefetch optional parameters
Date: Mon, 24 Oct 2016 11:25:21 +0530 [thread overview]
Message-ID: <1477288523-10819-2-git-send-email-vijay.kilari@gmail.com> (raw)
In-Reply-To: <1477288523-10819-1-git-send-email-vijay.kilari@gmail.com>
From: Vijaya Kumar K <Vijaya.Kumar@cavium.com>
Optional parameters of __builtin_prefetch() which specifies
rw and locality to 0's. For checking buffer is zero, set rw as read
and temporal locality to 0.
On arm64, __builtin_prefetch(addr) generates 'prfm pldl1keep'
where __builtin_prefetch(addr, 0, 0) generates 'prfm pldl1strm'
instruction which is optimal for this use case
Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@cavium.com>
---
util/bufferiszero.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/util/bufferiszero.c b/util/bufferiszero.c
index eb974b7..421d945 100644
--- a/util/bufferiszero.c
+++ b/util/bufferiszero.c
@@ -49,7 +49,7 @@ buffer_zero_int(const void *buf, size_t len)
const uint64_t *e = (uint64_t *)(((uintptr_t)buf + len) & -8);
for (; p + 8 <= e; p += 8) {
- __builtin_prefetch(p + 8);
+ __builtin_prefetch(p + 8, 0, 0);
if (t) {
return false;
}
@@ -86,7 +86,7 @@ buffer_zero_sse2(const void *buf, size_t len)
/* Loop over 16-byte aligned blocks of 64. */
while (likely(p <= e)) {
- __builtin_prefetch(p);
+ __builtin_prefetch(p, 0, 0);
t = _mm_cmpeq_epi8(t, zero);
if (unlikely(_mm_movemask_epi8(t) != 0xFFFF)) {
return false;
@@ -127,7 +127,7 @@ buffer_zero_sse4(const void *buf, size_t len)
/* Loop over 16-byte aligned blocks of 64. */
while (likely(p <= e)) {
- __builtin_prefetch(p);
+ __builtin_prefetch(p, 0, 0);
if (unlikely(!_mm_testz_si128(t, t))) {
return false;
}
@@ -162,7 +162,7 @@ buffer_zero_avx2(const void *buf, size_t len)
if (likely(p <= e)) {
/* Loop over 32-byte aligned blocks of 128. */
do {
- __builtin_prefetch(p);
+ __builtin_prefetch(p, 0, 0);
if (unlikely(!_mm256_testz_si256(t, t))) {
return false;
}
@@ -303,7 +303,7 @@ bool buffer_is_zero(const void *buf, size_t len)
}
/* Fetch the beginning of the buffer while we select the accelerator. */
- __builtin_prefetch(buf);
+ __builtin_prefetch(buf, 0, 0);
/* Use an optimized zero check if possible. Note that this also
includes a check for an unrolled loop over 64-bit integers. */
--
1.9.1
next prev parent reply other threads:[~2016-10-24 5:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 5:55 [Qemu-devel] [PATCH v3 0/3] Live migration optimization for Thunderx platform vijay.kilari
2016-10-24 5:55 ` vijay.kilari [this message]
2016-10-24 15:43 ` [Qemu-devel] [PATCH v3 1/3] cutils: Set __builtin_prefetch optional parameters Richard Henderson
2016-10-24 5:55 ` [Qemu-devel] [PATCH v3 2/3] utils: Add helper to read arm MIDR_EL1 register vijay.kilari
2016-10-24 9:39 ` Dr. David Alan Gilbert
2016-10-24 10:20 ` Vijay Kilari
2016-10-24 11:26 ` Paolo Bonzini
2016-10-24 15:47 ` Richard Henderson
2016-10-24 5:55 ` [Qemu-devel] [PATCH v3 3/3] utils: Add prefetch for Thunderx platform vijay.kilari
2016-10-24 11:25 ` Paolo Bonzini
2016-10-24 15:51 ` Richard Henderson
2016-10-24 15:47 ` [Qemu-devel] [PATCH v3 0/3] Live migration optimization " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477288523-10819-2-git-send-email-vijay.kilari@gmail.com \
--to=vijay.kilari@gmail.com \
--cc=Vijaya.Kumar@cavium.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).