From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byi8P-0004d5-Qi for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:30:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byi8K-0004C9-V0 for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:30:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44066) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byi8K-0004Ba-Po for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:29:56 -0400 From: Eduardo Habkost Date: Mon, 24 Oct 2016 14:25:49 -0200 Message-Id: <1477326349-30386-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH] tests: Remove unneeded "-vnc none" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, "Michael S. Tsirkin" Cc: Corey Minyard , Kevin Wolf , John Snow Some tests use the "-vnc none" option without any clear reason, making those tests break when --disable-vnc is specified on ./configure. Remove the unnecessary option. Signed-off-by: Eduardo Habkost --- tests/ide-test.c | 1 - tests/ipmi-bt-test.c | 2 +- tests/ipmi-kcs-test.c | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index a8a4081..3fbcb75 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -582,7 +582,6 @@ static void test_retry_flush(const char *machine) prepare_blkdebug_script(debug_path, "flush_to_disk"); ide_test_start( - "-vnc none " "-drive file=blkdebug:%s:%s,if=ide,cache=writeback,format=raw," "rerror=stop,werror=stop", debug_path, tmp_path); diff --git a/tests/ipmi-bt-test.c b/tests/ipmi-bt-test.c index be9005e..ad1e97e 100644 --- a/tests/ipmi-bt-test.c +++ b/tests/ipmi-bt-test.c @@ -415,7 +415,7 @@ int main(int argc, char **argv) /* Run the tests */ g_test_init(&argc, &argv, NULL); - cmdline = g_strdup_printf("-vnc none" + cmdline = g_strdup_printf( " -chardev socket,id=ipmi0,host=localhost,port=%d,reconnect=10" " -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0" " -device isa-ipmi-bt,bmc=bmc0", emu_port); diff --git a/tests/ipmi-kcs-test.c b/tests/ipmi-kcs-test.c index 3750389..9cf0b34 100644 --- a/tests/ipmi-kcs-test.c +++ b/tests/ipmi-kcs-test.c @@ -276,7 +276,7 @@ int main(int argc, char **argv) /* Run the tests */ g_test_init(&argc, &argv, NULL); - cmdline = g_strdup_printf("-vnc none -device ipmi-bmc-sim,id=bmc0" + cmdline = g_strdup_printf("-device ipmi-bmc-sim,id=bmc0" " -device isa-ipmi-kcs,bmc=bmc0"); qtest_start(cmdline); qtest_irq_intercept_in(global_qtest, "ioapic"); -- 2.7.4