From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byie4-0003Yg-DF for qemu-devel@nongnu.org; Mon, 24 Oct 2016 13:02:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byie3-0005B0-OH for qemu-devel@nongnu.org; Mon, 24 Oct 2016 13:02:44 -0400 From: Kevin Wolf Date: Mon, 24 Oct 2016 19:02:06 +0200 Message-Id: <1477328531-30879-19-git-send-email-kwolf@redhat.com> In-Reply-To: <1477328531-30879-1-git-send-email-kwolf@redhat.com> References: <1477328531-30879-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 18/23] block: Assert that bdrv_release_dirty_bitmap succeeded List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Fam Zheng We use a loop over bs->dirty_bitmaps to make sure the caller is only releasing a bitmap owned by bs. Let's also assert that in this case the caller is releasing a bitmap that does exist. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Signed-off-by: John Snow Message-id: 1476395910-8697-7-git-send-email-jsnow@redhat.com Signed-off-by: Max Reitz --- block/dirty-bitmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 860acc9..31d5296 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitmap.c @@ -305,6 +305,9 @@ static void bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs, } } } + if (bitmap) { + abort(); + } } void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap) -- 1.8.3.1