From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byidm-0003El-Ap for qemu-devel@nongnu.org; Mon, 24 Oct 2016 13:02:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byidl-0004zm-M4 for qemu-devel@nongnu.org; Mon, 24 Oct 2016 13:02:26 -0400 From: Kevin Wolf Date: Mon, 24 Oct 2016 19:01:49 +0200 Message-Id: <1477328531-30879-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1477328531-30879-1-git-send-email-kwolf@redhat.com> References: <1477328531-30879-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 01/23] block: failed qemu-img command should return non-zero exit code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Xu Tian If the backing file cannot be opened when doing qemu-img rebase, the variable 'ret' was not assigned a non-zero value, and the qemu-img process terminated with exit code zero. Fix this. Signed-off-by: Xu Tian Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-img.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index 67e8512..ab395a9 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -2956,6 +2956,7 @@ static int img_rebase(int argc, char **argv) error_reportf_err(local_err, "Could not open old backing file '%s': ", backing_name); + ret = -1; goto out; } @@ -2973,6 +2974,7 @@ static int img_rebase(int argc, char **argv) error_reportf_err(local_err, "Could not open new backing file '%s': ", out_baseimg); + ret = -1; goto out; } } -- 1.8.3.1