From: Ashijeet Acharya <ashijeetacharya@gmail.com>
To: kwolf@redhat.com
Cc: rjones@redhat.com, jcody@redhat.com, mreitz@redhat.com,
eblake@redhat.com, berrange@redhat.com, pbonzini@redhat.com,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Ashijeet Acharya <ashijeetacharya@gmail.com>
Subject: [Qemu-devel] [PATCH v4 2/5] util/qemu-sockets: Make inet_connect_saddr() public
Date: Tue, 25 Oct 2016 18:33:58 +0530 [thread overview]
Message-ID: <1477400641-7750-3-git-send-email-ashijeetacharya@gmail.com> (raw)
In-Reply-To: <1477400641-7750-1-git-send-email-ashijeetacharya@gmail.com>
Make inet_connect_saddr() in util/qemu-sockets.c public in order to be
able to use it with InetSocketAddress sockets outside of
util/qemu-sockets.c independently.
Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
include/qemu/sockets.h | 2 ++
util/qemu-sockets.c | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
index 9eb2470..5589e68 100644
--- a/include/qemu/sockets.h
+++ b/include/qemu/sockets.h
@@ -34,6 +34,8 @@ typedef void NonBlockingConnectHandler(int fd, Error *err, void *opaque);
InetSocketAddress *inet_parse(const char *str, Error **errp);
int inet_connect(const char *str, Error **errp);
+int inet_connect_saddr(InetSocketAddress *saddr, Error **errp,
+ NonBlockingConnectHandler *callback, void *opaque);
NetworkAddressFamily inet_netfamily(int family);
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 4cef549..31f7fc6 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -412,8 +412,8 @@ static struct addrinfo *inet_parse_connect_saddr(InetSocketAddress *saddr,
* function succeeds, callback will be called when the connection
* completes, with the file descriptor on success, or -1 on error.
*/
-static int inet_connect_saddr(InetSocketAddress *saddr, Error **errp,
- NonBlockingConnectHandler *callback, void *opaque)
+int inet_connect_saddr(InetSocketAddress *saddr, Error **errp,
+ NonBlockingConnectHandler *callback, void *opaque)
{
Error *local_err = NULL;
struct addrinfo *res, *e;
--
2.6.2
next prev parent reply other threads:[~2016-10-25 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 13:03 [Qemu-devel] [PATCH v4 0/5] Allow blockdev-add for SSH Ashijeet Acharya
2016-10-25 13:03 ` [Qemu-devel] [PATCH v4 1/5] block/ssh: Add ssh_has_filename_options_conflict() Ashijeet Acharya
2016-10-25 13:03 ` Ashijeet Acharya [this message]
2016-10-25 13:03 ` [Qemu-devel] [PATCH v4 3/5] block/ssh: Add InetSocketAddress and accept it Ashijeet Acharya
2016-10-25 13:04 ` [Qemu-devel] [PATCH v4 4/5] block/ssh: Use InetSocketAddress options Ashijeet Acharya
2016-10-25 13:04 ` [Qemu-devel] [PATCH v4 5/5] qapi: allow blockdev-add for ssh Ashijeet Acharya
2016-10-25 19:58 ` Eric Blake
2016-10-26 8:31 ` Kevin Wolf
2016-10-26 13:27 ` Eric Blake
2016-10-27 19:54 ` [Qemu-devel] [PATCH v4 0/5] Allow blockdev-add for SSH Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477400641-7750-3-git-send-email-ashijeetacharya@gmail.com \
--to=ashijeetacharya@gmail.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).