From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz2os-0004lm-Hw for qemu-devel@nongnu.org; Tue, 25 Oct 2016 10:35:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz2oo-0007jm-Iu for qemu-devel@nongnu.org; Tue, 25 Oct 2016 10:35:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41512) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bz2oo-0007jK-B9 for qemu-devel@nongnu.org; Tue, 25 Oct 2016 10:35:10 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99A308E3FA for ; Tue, 25 Oct 2016 14:35:09 +0000 (UTC) From: Markus Armbruster Date: Tue, 25 Oct 2016 16:35:04 +0200 Message-Id: <1477406107-10757-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: berrange@redhat.com, kwolf@redhat.com, eblake@redhat.com This is how I propose to rearrange PATCH 04+05 of Dan's "[PATCH v14 00/21] QAPI/QOM work for non-scalar object properties" (really v15) in my pull request, to make git's rename detection work. The result is identical except for two comments I touched up: diff --git a/include/qapi/qobject-output-visitor.h b/include/qapi/qobject-output-visitor.h index 358c959..8241877 100644 --- a/include/qapi/qobject-output-visitor.h +++ b/include/qapi/qobject-output-visitor.h @@ -20,7 +20,7 @@ typedef struct QObjectOutputVisitor QObjectOutputVisitor; /* - * Create a new QOBJECT output visitor. + * Create a new QObject output visitor. * * If everything else succeeds, pass @result to visit_complete() to * collect the result of the visit. diff --git a/qapi/qobject-output-visitor.c b/qapi/qobject-output-visitor.c index df43cb8..8711270 100644 --- a/qapi/qobject-output-visitor.c +++ b/qapi/qobject-output-visitor.c @@ -150,7 +150,7 @@ static void qobject_output_type_int64(Visitor *v, const char *name, static void qobject_output_type_uint64(Visitor *v, const char *name, uint64_t *obj, Error **errp) { - /* FIXME: QOBJECT outputs values larger than INT64_MAX as negative */ + /* FIXME values larger than INT64_MAX become negative */ QObjectOutputVisitor *qov = to_qov(v); qobject_output_add(qov, name, qint_from_int(*obj)); } Daniel P. Berrange (3): qapi: rename *qmp-*-visitor* to *qobject-*-visitor* qapi: rename QmpInputVisitor to QObjectInputVisitor qapi: rename QmpOutputVisitor to QObjectOutputVisitor block/qapi.c | 4 +- blockdev.c | 4 +- docs/qapi-code-gen.txt | 4 +- ...qmp-input-visitor.h => qobject-input-visitor.h} | 10 +- ...p-output-visitor.h => qobject-output-visitor.h} | 10 +- include/qapi/visitor.h | 6 +- monitor.c | 2 +- qapi/Makefile.objs | 4 +- qapi/qapi-clone-visitor.c | 2 +- qapi/qmp-output-visitor.c | 256 --------------------- ...qmp-input-visitor.c => qobject-input-visitor.c} | 170 +++++++------- qapi/qobject-output-visitor.c | 254 ++++++++++++++++++++ qemu-img.c | 8 +- qmp.c | 4 +- qom/object_interfaces.c | 2 +- qom/qom-qobject.c | 8 +- scripts/qapi-commands.py | 8 +- scripts/qapi-event.py | 4 +- target-s390x/cpu_models.c | 4 +- tests/.gitignore | 6 +- tests/Makefile.include | 20 +- tests/check-qnull.c | 8 +- tests/test-qmp-commands.c | 4 +- ...-input-strict.c => test-qobject-input-strict.c} | 6 +- ...nput-visitor.c => test-qobject-input-visitor.c} | 6 +- ...put-visitor.c => test-qobject-output-visitor.c} | 6 +- tests/test-string-input-visitor.c | 2 +- tests/test-string-output-visitor.c | 2 +- tests/test-visitor-serialization.c | 8 +- util/qemu-sockets.c | 4 +- 30 files changed, 418 insertions(+), 418 deletions(-) rename include/qapi/{qmp-input-visitor.h => qobject-input-visitor.h} (63%) rename include/qapi/{qmp-output-visitor.h => qobject-output-visitor.h} (66%) delete mode 100644 qapi/qmp-output-visitor.c rename qapi/{qmp-input-visitor.c => qobject-input-visitor.c} (59%) create mode 100644 qapi/qobject-output-visitor.c rename tests/{test-qmp-input-strict.c => test-qobject-input-strict.c} (98%) rename tests/{test-qmp-input-visitor.c => test-qobject-input-visitor.c} (99%) rename tests/{test-qmp-output-visitor.c => test-qobject-output-visitor.c} (99%) -- 2.5.5