From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH] trace: Fix 'char **' compilation error in simple backend
Date: Wed, 26 Oct 2016 09:59:32 +0800 [thread overview]
Message-ID: <1477447172-19677-1-git-send-email-famz@redhat.com> (raw)
Currently, the generated function body will do "strlen(arg)" but the
argument could be 'char **'. Avoid that by exclusding such cases in
is_string check.
Reported by patchew's "make docker-test-mingw@fedora".
Signed-off-by: Fam Zheng <famz@redhat.com>
---
scripts/tracetool/backend/simple.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/tracetool/backend/simple.py b/scripts/tracetool/backend/simple.py
index 9885e83..2538795 100644
--- a/scripts/tracetool/backend/simple.py
+++ b/scripts/tracetool/backend/simple.py
@@ -21,7 +21,9 @@ PUBLIC = True
def is_string(arg):
strtype = ('const char*', 'char*', 'const char *', 'char *')
- if arg.lstrip().startswith(strtype):
+ non_strtype = ('const char**', 'char**', 'const char **', 'char **')
+ arg_strip = arg.lstrip()
+ if arg_strip.startswith(strtype) and not arg_strip.startswith(non_strtype):
return True
else:
return False
--
2.7.4
next reply other threads:[~2016-10-26 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 1:59 Fam Zheng [this message]
2016-10-26 2:29 ` [Qemu-devel] [PATCH] trace: Fix 'char **' compilation error in simple backend Eric Blake
2016-10-26 2:46 ` Fam Zheng
2016-10-26 2:56 ` Eric Blake
2016-10-26 3:05 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477447172-19677-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).