qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: Li Qiang <liqiang6-s@360.cn>, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL 4/9] net: eepro100: fix memory leak in device uninit
Date: Wed, 26 Oct 2016 10:24:06 +0800	[thread overview]
Message-ID: <1477448651-4474-5-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1477448651-4474-1-git-send-email-jasowang@redhat.com>

From: Li Qiang <liqiang6-s@360.cn>

The exit dispatch of eepro100 network card device doesn't free
the 's->vmstate' field which was allocated in device realize thus
leading a host memory leak. This patch avoid this.

Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/net/eepro100.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
index bab4dbf..4bf71f2 100644
--- a/hw/net/eepro100.c
+++ b/hw/net/eepro100.c
@@ -1843,6 +1843,7 @@ static void pci_nic_uninit(PCIDevice *pci_dev)
     EEPRO100State *s = DO_UPCAST(EEPRO100State, dev, pci_dev);
 
     vmstate_unregister(&pci_dev->qdev, s->vmstate, s);
+    g_free(s->vmstate);
     eeprom93xx_free(&pci_dev->qdev, s->eeprom);
     qemu_del_nic(s->nic);
 }
-- 
2.7.4

  parent reply	other threads:[~2016-10-26  2:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26  2:24 [Qemu-devel] [PULL 0/9] Net patches Jason Wang
2016-10-26  2:24 ` [Qemu-devel] [PULL 1/9] net: pcnet: check rx/tx descriptor ring length Jason Wang
2016-10-26  2:24 ` [Qemu-devel] [PULL 2/9] net: pcnet: fix source formatting and indentation Jason Wang
2016-10-26  2:24 ` [Qemu-devel] [PULL 3/9] tap-bsd: OpenBSD uses tap(4) now Jason Wang
2016-10-26  2:24 ` Jason Wang [this message]
2016-10-26  2:24 ` [Qemu-devel] [PULL 5/9] net: rocker: set limit to DMA buffer size Jason Wang
2016-10-26  2:24 ` [Qemu-devel] [PULL 6/9] e1000e: Don't zero out buffer address in rx descriptor Jason Wang
2016-10-26  2:24 ` [Qemu-devel] [PULL 7/9] net: vmxnet: initialise local tx descriptor Jason Wang
2016-10-26  2:24 ` [Qemu-devel] [PULL 8/9] net: rtl8139: limit processing of ring descriptors Jason Wang
2016-10-26  2:24 ` [Qemu-devel] [PULL 9/9] colo-proxy: fix memory leak Jason Wang
2016-10-30 12:13   ` Greg Kurz
2016-10-31  6:37     ` Zhang Chen
2016-10-31  7:40       ` Jason Wang
2016-10-31  8:05         ` Zhang Chen
2016-10-31  9:30           ` Greg Kurz
2016-10-27 12:31 ` [Qemu-devel] [PULL 0/9] Net patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477448651-4474-5-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=liqiang6-s@360.cn \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).