From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzDtJ-0000R5-Az for qemu-devel@nongnu.org; Tue, 25 Oct 2016 22:24:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzDtF-0000cV-DD for qemu-devel@nongnu.org; Tue, 25 Oct 2016 22:24:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43630) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzDtF-0000cP-82 for qemu-devel@nongnu.org; Tue, 25 Oct 2016 22:24:29 -0400 From: Jason Wang Date: Wed, 26 Oct 2016 10:24:06 +0800 Message-Id: <1477448651-4474-5-git-send-email-jasowang@redhat.com> In-Reply-To: <1477448651-4474-1-git-send-email-jasowang@redhat.com> References: <1477448651-4474-1-git-send-email-jasowang@redhat.com> Subject: [Qemu-devel] [PULL 4/9] net: eepro100: fix memory leak in device uninit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: Li Qiang , Jason Wang From: Li Qiang The exit dispatch of eepro100 network card device doesn't free the 's->vmstate' field which was allocated in device realize thus leading a host memory leak. This patch avoid this. Signed-off-by: Li Qiang Signed-off-by: Jason Wang --- hw/net/eepro100.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index bab4dbf..4bf71f2 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -1843,6 +1843,7 @@ static void pci_nic_uninit(PCIDevice *pci_dev) EEPRO100State *s = DO_UPCAST(EEPRO100State, dev, pci_dev); vmstate_unregister(&pci_dev->qdev, s->vmstate, s); + g_free(s->vmstate); eeprom93xx_free(&pci_dev->qdev, s->eeprom); qemu_del_nic(s->nic); } -- 2.7.4