qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: agraf@suse.de, clg@kaod.org, thuth@redhat.com,
	lvivier@redhat.com, aik@ozlabs.ru, mark.cave-ayland@ilande.co.uk,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 20/49] pseries: Remove unused callbacks from sPAPR VIO bus state
Date: Wed, 26 Oct 2016 22:42:24 +1100	[thread overview]
Message-ID: <1477482173-8761-21-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1477482173-8761-1-git-send-email-david@gibson.dropbear.id.au>

The original QOMification of the spapr VIO devices in 3954d33 "spapr:
convert to QEMU Object Model (v2)" moved some callbacks from the
VIOsPAPRBus structure to the VIOsPAPRDeviceClass.  Except, that it
forgot to actually remove them from the VIOsPAPRBus structure (which
still exists, though it doesn't fulfill quite the same function as it
did pre-QOM).

This patch removes those now unused callback fields.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
 include/hw/ppc/spapr_vio.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/hw/ppc/spapr_vio.h b/include/hw/ppc/spapr_vio.h
index 40d0e5f..0b025fd 100644
--- a/include/hw/ppc/spapr_vio.h
+++ b/include/hw/ppc/spapr_vio.h
@@ -76,8 +76,6 @@ struct VIOsPAPRDevice {
 struct VIOsPAPRBus {
     BusState bus;
     uint32_t next_reg;
-    int (*init)(VIOsPAPRDevice *dev);
-    int (*devnode)(VIOsPAPRDevice *dev, void *fdt, int node_off);
 };
 
 extern VIOsPAPRBus *spapr_vio_bus_init(void);
-- 
2.7.4

  parent reply	other threads:[~2016-10-26 11:43 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 11:42 [Qemu-devel] [PULL 00/49] ppc-for-2.8 queue 20161026 David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 01/49] pseries: Update SLOF firmware image to 20161019 David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 02/49] ppc/xics: Add xics to the monitor "info pic" command David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 03/49] tests: fix memory leak in virtio-scsi-test David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 04/49] tests: don't check if qtest_spapr_boot() returns NULL David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 05/49] tests: move QVirtioBus pointer into QVirtioDevice David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 06/49] tests: rename target_big_endian() as qvirtio_is_big_endian() David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 07/49] tests: use qtest_pc_boot()/qtest_shutdown() in virtio tests David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 08/49] tests: enable virtio tests on SPAPR David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 09/49] spapr_pci: advertise explicit numa IDs even when there's 1 node David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 10/49] nvram: Introduce helper functions for CHRP "system" and "free space" partitions David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 11/49] sparc: Use the new common NVRAM functions for system and free space partition David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 12/49] nvram: Move the remaining CHRP NVRAM related code to chrp_nvram.[ch] David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 13/49] nvram: Rename openbios_firmware_abi.h into sun_nvram.h David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 14/49] target-ppc: implement vnegw/d instructions David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 15/49] target-ppc: implement xxbr[qdwh] instruction David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 16/49] ppc/xics: add a xics_set_nr_servers common routine David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 17/49] ppc/xics: add a XICSState backlink in ICPState David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 18/49] ppc/xics: change the icp_ routines API to use an 'ICPState *' argument David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 19/49] ppc: fix MSR_ME handling for system reset interrupt David Gibson
2016-10-26 11:42 ` David Gibson [this message]
2016-10-26 11:42 ` [Qemu-devel] [PULL 21/49] ppc: Fix single step with gdb stub David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 22/49] ppc: add skiboot firmware for the pnv platform David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 23/49] ppc/pnv: add skeleton PowerNV platform David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 24/49] ppc/pnv: add a PnvChip object David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 25/49] ppc/pnv: add a core mask to PnvChip David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 26/49] ppc/pnv: add a PIR handler " David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 27/49] ppc/pnv: add a PnvCore object David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 28/49] ppc/pnv: add XSCOM infrastructure David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 29/49] ppc/pnv: add XSCOM handlers to PnvCore David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 30/49] ppc/pnv: add a LPC controller David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 31/49] ppc/pnv: add a ISA bus David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 32/49] target-ppc: add vmul10[u, eu, cu, ecu]q instructions David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 33/49] pseries: Split device tree construction from device tree load David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 34/49] pseries: Remove rtas_addr and fdt_addr fields from machinestate David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 35/49] pseries: Make spapr_create_fdt_skel() get information from machine state David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 36/49] pseries: Move adding of fdt reserve map entries David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 37/49] pseries: Consolidate RTAS loading David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 38/49] pseries: Move construction of /interrupt-controller fdt node David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 39/49] pseries: Consolidate construction of /chosen device tree node David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 40/49] pseries: Consolidate construction of /rtas " David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 41/49] pseries: Move /event-sources construction to spapr_build_fdt() David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 42/49] pseries: Move /hypervisor node construction to fdt_build_fdt() David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 43/49] pseries: Consolidate construction of /vdevice device tree node David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 44/49] pseries: Remove spapr_create_fdt_skel() David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 45/49] spapr_ovec: initial implementation of option vector helpers David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 46/49] spapr_hcall: use spapr_ovec_* interfaces for CAS options David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 47/49] spapr: add option vector handling in CAS-generated resets David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 48/49] spapr: improve ibm, architecture-vec-5 property handling David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 49/49] adb: change handler only when recognized David Gibson
2016-10-27 13:06 ` [Qemu-devel] [PULL 00/49] ppc-for-2.8 queue 20161026 Peter Maydell
2016-10-27 13:34   ` David Gibson
2016-10-27 14:05     ` Peter Maydell
2016-10-27 14:25     ` Cédric Le Goater
2016-10-27 22:38       ` David Gibson
2016-10-27 13:52   ` Cédric Le Goater
2016-10-27 13:58     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477482173-8761-21-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=clg@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).