From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: agraf@suse.de, clg@kaod.org, thuth@redhat.com,
lvivier@redhat.com, aik@ozlabs.ru, mark.cave-ayland@ilande.co.uk,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 32/49] target-ppc: add vmul10[u, eu, cu, ecu]q instructions
Date: Wed, 26 Oct 2016 22:42:36 +1100 [thread overview]
Message-ID: <1477482173-8761-33-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1477482173-8761-1-git-send-email-david@gibson.dropbear.id.au>
From: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
vmul10uq : Vector Multiply-by-10 Unsigned Quadword VX-form
vmul10euq : Vector Multiply-by-10 Extended Unsigned Quadword VX-form
vmul10cuq : Vector Multiply-by-10 & write Carry Unsigned Quadword VX-form
vmul10ecuq: Vector Multiply-by-10 Extended & write Carry Unsigned Quadword VX-form
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
[ Add GEN_VXFORM_DUAL_EXT with invalid bit mask ]
Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
target-ppc/translate/vmx-impl.inc.c | 72 +++++++++++++++++++++++++++++++++++++
target-ppc/translate/vmx-ops.inc.c | 8 ++---
2 files changed, 76 insertions(+), 4 deletions(-)
diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/vmx-impl.inc.c
index 563f101..fc612d9 100644
--- a/target-ppc/translate/vmx-impl.inc.c
+++ b/target-ppc/translate/vmx-impl.inc.c
@@ -182,6 +182,52 @@ static void gen_mtvscr(DisasContext *ctx)
tcg_temp_free_ptr(p);
}
+#define GEN_VX_VMUL10(name, add_cin, ret_carry) \
+static void glue(gen_, name)(DisasContext *ctx) \
+{ \
+ TCGv_i64 t0 = tcg_temp_new_i64(); \
+ TCGv_i64 t1 = tcg_temp_new_i64(); \
+ TCGv_i64 t2 = tcg_temp_new_i64(); \
+ TCGv_i64 ten, z; \
+ \
+ if (unlikely(!ctx->altivec_enabled)) { \
+ gen_exception(ctx, POWERPC_EXCP_VPU); \
+ return; \
+ } \
+ \
+ ten = tcg_const_i64(10); \
+ z = tcg_const_i64(0); \
+ \
+ if (add_cin) { \
+ tcg_gen_mulu2_i64(t0, t1, cpu_avrl[rA(ctx->opcode)], ten); \
+ tcg_gen_andi_i64(t2, cpu_avrl[rB(ctx->opcode)], 0xF); \
+ tcg_gen_add2_i64(cpu_avrl[rD(ctx->opcode)], t2, t0, t1, t2, z); \
+ } else { \
+ tcg_gen_mulu2_i64(cpu_avrl[rD(ctx->opcode)], t2, \
+ cpu_avrl[rA(ctx->opcode)], ten); \
+ } \
+ \
+ if (ret_carry) { \
+ tcg_gen_mulu2_i64(t0, t1, cpu_avrh[rA(ctx->opcode)], ten); \
+ tcg_gen_add2_i64(t0, cpu_avrl[rD(ctx->opcode)], t0, t1, t2, z); \
+ tcg_gen_movi_i64(cpu_avrh[rD(ctx->opcode)], 0); \
+ } else { \
+ tcg_gen_mul_i64(t0, cpu_avrh[rA(ctx->opcode)], ten); \
+ tcg_gen_add_i64(cpu_avrh[rD(ctx->opcode)], t0, t2); \
+ } \
+ \
+ tcg_temp_free_i64(t0); \
+ tcg_temp_free_i64(t1); \
+ tcg_temp_free_i64(t2); \
+ tcg_temp_free_i64(ten); \
+ tcg_temp_free_i64(z); \
+} \
+
+GEN_VX_VMUL10(vmul10uq, 0, 0);
+GEN_VX_VMUL10(vmul10euq, 1, 0);
+GEN_VX_VMUL10(vmul10cuq, 0, 1);
+GEN_VX_VMUL10(vmul10ecuq, 1, 1);
+
/* Logical operations */
#define GEN_VX_LOGICAL(name, tcg_op, opc2, opc3) \
static void glue(gen_, name)(DisasContext *ctx) \
@@ -276,8 +322,30 @@ static void glue(gen_, name0##_##name1)(DisasContext *ctx) \
} \
}
+/* Adds support to provide invalid mask */
+#define GEN_VXFORM_DUAL_EXT(name0, flg0, flg2_0, inval0, \
+ name1, flg1, flg2_1, inval1) \
+static void glue(gen_, name0##_##name1)(DisasContext *ctx) \
+{ \
+ if ((Rc(ctx->opcode) == 0) && \
+ ((ctx->insns_flags & flg0) || (ctx->insns_flags2 & flg2_0)) && \
+ !(ctx->opcode & inval0)) { \
+ gen_##name0(ctx); \
+ } else if ((Rc(ctx->opcode) == 1) && \
+ ((ctx->insns_flags & flg1) || (ctx->insns_flags2 & flg2_1)) && \
+ !(ctx->opcode & inval1)) { \
+ gen_##name1(ctx); \
+ } else { \
+ gen_inval_exception(ctx, POWERPC_EXCP_INVAL_INVAL); \
+ } \
+}
+
GEN_VXFORM(vaddubm, 0, 0);
+GEN_VXFORM_DUAL_EXT(vaddubm, PPC_ALTIVEC, PPC_NONE, 0, \
+ vmul10cuq, PPC_NONE, PPC2_ISA300, 0x0000F800)
GEN_VXFORM(vadduhm, 0, 1);
+GEN_VXFORM_DUAL(vadduhm, PPC_ALTIVEC, PPC_NONE, \
+ vmul10ecuq, PPC_NONE, PPC2_ISA300)
GEN_VXFORM(vadduwm, 0, 2);
GEN_VXFORM(vaddudm, 0, 3);
GEN_VXFORM(vsububm, 0, 16);
@@ -390,7 +458,11 @@ GEN_VXFORM(vsro, 6, 17);
GEN_VXFORM(vaddcuw, 0, 6);
GEN_VXFORM(vsubcuw, 0, 22);
GEN_VXFORM_ENV(vaddubs, 0, 8);
+GEN_VXFORM_DUAL_EXT(vaddubs, PPC_ALTIVEC, PPC_NONE, 0, \
+ vmul10uq, PPC_NONE, PPC2_ISA300, 0x0000F800)
GEN_VXFORM_ENV(vadduhs, 0, 9);
+GEN_VXFORM_DUAL(vadduhs, PPC_ALTIVEC, PPC_NONE, \
+ vmul10euq, PPC_NONE, PPC2_ISA300)
GEN_VXFORM_ENV(vadduws, 0, 10);
GEN_VXFORM_ENV(vaddsbs, 0, 12);
GEN_VXFORM_ENV(vaddshs, 0, 13);
diff --git a/target-ppc/translate/vmx-ops.inc.c b/target-ppc/translate/vmx-ops.inc.c
index ab64ab2..cc7ed7e 100644
--- a/target-ppc/translate/vmx-ops.inc.c
+++ b/target-ppc/translate/vmx-ops.inc.c
@@ -55,8 +55,8 @@ GEN_HANDLER_E(name0##_##name1, 0x4, opc2, opc3, 0x00000000, type0, type1)
GEN_HANDLER_E(name0##_##name1, 0x4, opc2, opc3, 0x00000000, tp0, tp1), \
GEN_HANDLER_E(name0##_##name1, 0x4, opc2, (opc3 | 0x10), 0x00000000, tp0, tp1),
-GEN_VXFORM(vaddubm, 0, 0),
-GEN_VXFORM(vadduhm, 0, 1),
+GEN_VXFORM_DUAL(vaddubm, vmul10cuq, 0, 0, PPC_ALTIVEC, PPC_NONE),
+GEN_VXFORM_DUAL(vadduhm, vmul10ecuq, 0, 1, PPC_ALTIVEC, PPC_NONE),
GEN_VXFORM(vadduwm, 0, 2),
GEN_VXFORM_207(vaddudm, 0, 3),
GEN_VXFORM_DUAL(vsububm, bcdadd, 0, 16, PPC_ALTIVEC, PPC_NONE),
@@ -123,8 +123,8 @@ GEN_VXFORM(vslo, 6, 16),
GEN_VXFORM(vsro, 6, 17),
GEN_VXFORM(vaddcuw, 0, 6),
GEN_VXFORM(vsubcuw, 0, 22),
-GEN_VXFORM(vaddubs, 0, 8),
-GEN_VXFORM(vadduhs, 0, 9),
+GEN_VXFORM_DUAL(vaddubs, vmul10uq, 0, 8, PPC_ALTIVEC, PPC_NONE),
+GEN_VXFORM_DUAL(vadduhs, vmul10euq, 0, 9, PPC_ALTIVEC, PPC_NONE),
GEN_VXFORM(vadduws, 0, 10),
GEN_VXFORM(vaddsbs, 0, 12),
GEN_VXFORM(vaddshs, 0, 13),
--
2.7.4
next prev parent reply other threads:[~2016-10-26 11:44 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 11:42 [Qemu-devel] [PULL 00/49] ppc-for-2.8 queue 20161026 David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 01/49] pseries: Update SLOF firmware image to 20161019 David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 02/49] ppc/xics: Add xics to the monitor "info pic" command David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 03/49] tests: fix memory leak in virtio-scsi-test David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 04/49] tests: don't check if qtest_spapr_boot() returns NULL David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 05/49] tests: move QVirtioBus pointer into QVirtioDevice David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 06/49] tests: rename target_big_endian() as qvirtio_is_big_endian() David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 07/49] tests: use qtest_pc_boot()/qtest_shutdown() in virtio tests David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 08/49] tests: enable virtio tests on SPAPR David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 09/49] spapr_pci: advertise explicit numa IDs even when there's 1 node David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 10/49] nvram: Introduce helper functions for CHRP "system" and "free space" partitions David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 11/49] sparc: Use the new common NVRAM functions for system and free space partition David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 12/49] nvram: Move the remaining CHRP NVRAM related code to chrp_nvram.[ch] David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 13/49] nvram: Rename openbios_firmware_abi.h into sun_nvram.h David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 14/49] target-ppc: implement vnegw/d instructions David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 15/49] target-ppc: implement xxbr[qdwh] instruction David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 16/49] ppc/xics: add a xics_set_nr_servers common routine David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 17/49] ppc/xics: add a XICSState backlink in ICPState David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 18/49] ppc/xics: change the icp_ routines API to use an 'ICPState *' argument David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 19/49] ppc: fix MSR_ME handling for system reset interrupt David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 20/49] pseries: Remove unused callbacks from sPAPR VIO bus state David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 21/49] ppc: Fix single step with gdb stub David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 22/49] ppc: add skiboot firmware for the pnv platform David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 23/49] ppc/pnv: add skeleton PowerNV platform David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 24/49] ppc/pnv: add a PnvChip object David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 25/49] ppc/pnv: add a core mask to PnvChip David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 26/49] ppc/pnv: add a PIR handler " David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 27/49] ppc/pnv: add a PnvCore object David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 28/49] ppc/pnv: add XSCOM infrastructure David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 29/49] ppc/pnv: add XSCOM handlers to PnvCore David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 30/49] ppc/pnv: add a LPC controller David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 31/49] ppc/pnv: add a ISA bus David Gibson
2016-10-26 11:42 ` David Gibson [this message]
2016-10-26 11:42 ` [Qemu-devel] [PULL 33/49] pseries: Split device tree construction from device tree load David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 34/49] pseries: Remove rtas_addr and fdt_addr fields from machinestate David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 35/49] pseries: Make spapr_create_fdt_skel() get information from machine state David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 36/49] pseries: Move adding of fdt reserve map entries David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 37/49] pseries: Consolidate RTAS loading David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 38/49] pseries: Move construction of /interrupt-controller fdt node David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 39/49] pseries: Consolidate construction of /chosen device tree node David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 40/49] pseries: Consolidate construction of /rtas " David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 41/49] pseries: Move /event-sources construction to spapr_build_fdt() David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 42/49] pseries: Move /hypervisor node construction to fdt_build_fdt() David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 43/49] pseries: Consolidate construction of /vdevice device tree node David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 44/49] pseries: Remove spapr_create_fdt_skel() David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 45/49] spapr_ovec: initial implementation of option vector helpers David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 46/49] spapr_hcall: use spapr_ovec_* interfaces for CAS options David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 47/49] spapr: add option vector handling in CAS-generated resets David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 48/49] spapr: improve ibm, architecture-vec-5 property handling David Gibson
2016-10-26 11:42 ` [Qemu-devel] [PULL 49/49] adb: change handler only when recognized David Gibson
2016-10-27 13:06 ` [Qemu-devel] [PULL 00/49] ppc-for-2.8 queue 20161026 Peter Maydell
2016-10-27 13:34 ` David Gibson
2016-10-27 14:05 ` Peter Maydell
2016-10-27 14:25 ` Cédric Le Goater
2016-10-27 22:38 ` David Gibson
2016-10-27 13:52 ` Cédric Le Goater
2016-10-27 13:58 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477482173-8761-33-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=clg@kaod.org \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=lvivier@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=nikunj@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).