From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzNA0-0002BB-AI for qemu-devel@nongnu.org; Wed, 26 Oct 2016 08:18:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzN9v-0002Pf-Dw for qemu-devel@nongnu.org; Wed, 26 Oct 2016 08:18:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38988) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzN9v-0002PR-8t for qemu-devel@nongnu.org; Wed, 26 Oct 2016 08:18:19 -0400 Message-ID: <1477484297.18984.41.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 26 Oct 2016 14:18:17 +0200 In-Reply-To: <20161026114335.GB2811@var.bordeaux.inria.fr> References: <20161015195308.20473-1-samuel.thibault@ens-lyon.org> <20161025222616.GE2801@var.home> <1477476355.18984.32.camel@redhat.com> <20161026114335.GB2811@var.bordeaux.inria.fr> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/5] curses: wide character support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, berrange@redhat.com, peter.maydell@linaro.org, mjt@tls.msk.ru Hi, > > /me wonders whenever we should do the same with iconv. It's part of th= e > > POSIX.1-2001 specs, and we have 2016 now. Do we *really* need configur= e > > checks and #ifdefs for it? >=20 > I would only say that libiconv is not always installed by default on BSD > systems for instance. Hmm, maybe keep the check but disable curses altogether in case iconv isn't there, so we can at least avoid the #ifdefs? > You mean patches 1-3? Patch 5 would be very useful too to fix typing acce= nted > letters, and it doesn't depend on patch 4. Ok, then I'll go pick #5 too. cheers, Gerd