qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>
Subject: [Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplicate "bv" property
Date: Wed, 26 Oct 2016 14:30:19 -0200	[thread overview]
Message-ID: <1477499426-9550-2-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1477499426-9550-1-git-send-email-ehabkost@redhat.com>

The object_property_add_bool() call in dummy_init() is always
failing because there is an existing "bv" class property. We need
to remove either the "bv" class property or the "bv" instance
property.

Remove the class property so both object properties and class
properties are covered by the test code.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes series v2 -> v3:
* Reworded commit message for clarity
---
 tests/check-qom-proplist.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
index a16cefc..693dc4c 100644
--- a/tests/check-qom-proplist.c
+++ b/tests/check-qom-proplist.c
@@ -129,10 +129,6 @@ static void dummy_init(Object *obj)
 
 static void dummy_class_init(ObjectClass *cls, void *data)
 {
-    object_class_property_add_bool(cls, "bv",
-                                   dummy_get_bv,
-                                   dummy_set_bv,
-                                   NULL);
     object_class_property_add_str(cls, "sv",
                                   dummy_get_sv,
                                   dummy_set_sv,
-- 
2.7.4

  reply	other threads:[~2016-10-26 16:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 16:30 [Qemu-devel] [PATCH v3 0/8] qdev class properties + abstract class support on device-list-properties Eduardo Habkost
2016-10-26 16:30 ` Eduardo Habkost [this message]
2016-10-27 14:13   ` [Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplicate "bv" property Igor Mammedov
2016-10-26 16:30 ` [Qemu-devel] [PATCH v3 2/8] tests: check-qom-proplist: Use &error_abort to catch errors Eduardo Habkost
2016-10-27 14:16   ` Igor Mammedov
2016-10-26 16:30 ` [Qemu-devel] [PATCH v3 3/8] qdev: device_class_set_props() function Eduardo Habkost
2016-10-26 16:30 ` [Qemu-devel] [PATCH v3 4/8] qdev: Extract property-default code to qdev_property_set_to_default() Eduardo Habkost
2016-10-26 16:30 ` [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties Eduardo Habkost
2016-10-27 14:51   ` Igor Mammedov
2016-10-27 14:57     ` Eduardo Habkost
2016-10-27 15:30       ` Igor Mammedov
2016-10-27 16:37         ` Eduardo Habkost
2016-10-29 14:00           ` Igor Mammedov
2016-10-26 16:30 ` [Qemu-devel] [PATCH v3 6/8] qom: object_class_property_iter_init() function Eduardo Habkost
2016-10-27 15:34   ` Igor Mammedov
2016-10-27 16:49     ` Eduardo Habkost
2016-10-26 16:30 ` [Qemu-devel] [PATCH v3 7/8] qmp: Support abstract classes on device-list-properties Eduardo Habkost
2016-10-26 16:30 ` [Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code Eduardo Habkost
2016-10-26 16:48   ` Peter Maydell
2016-10-26 16:57     ` Eduardo Habkost
2016-10-26 17:57       ` Peter Maydell
2016-10-26 19:36         ` Eduardo Habkost
2016-10-27 19:48 ` [Qemu-devel] [PATCH v3 0/8] qdev class properties + abstract class support on device-list-properties Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477499426-9550-2-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).