From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org, Dmitry Fleytman <dmitry@daynix.com>,
Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PATCH 4/4] e1000e: Rename "subsys_ven" property to "subsys-vendor"
Date: Wed, 26 Oct 2016 17:21:58 -0200 [thread overview]
Message-ID: <1477509718-6969-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1477509718-6969-1-git-send-email-ehabkost@redhat.com>
Follow the usual QOM property naming style, and make the property
name clearer.
This breaks command-line compatibility, but I am assuming the
property is not being used in production by anybody.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/net/e1000e.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c
index 5a711a7..0b27da3 100644
--- a/hw/net/e1000e.c
+++ b/hw/net/e1000e.c
@@ -63,7 +63,7 @@ typedef struct E1000EState {
uint32_t ioaddr;
- uint16_t subsys_ven;
+ uint16_t subsys_vendor;
uint16_t subsys;
bool has_vnet;
@@ -418,7 +418,7 @@ static void e1000e_pci_realize(PCIDevice *pci_dev, Error **errp)
pci_dev->config[PCI_CACHE_LINE_SIZE] = 0x10;
pci_dev->config[PCI_INTERRUPT_PIN] = 1;
- pci_set_word(pci_dev->config + PCI_SUBSYSTEM_VENDOR_ID, s->subsys_ven);
+ pci_set_word(pci_dev->config + PCI_SUBSYSTEM_VENDOR_ID, s->subsys_vendor);
pci_set_word(pci_dev->config + PCI_SUBSYSTEM_ID, s->subsys);
/* Define IO/MMIO regions */
@@ -524,7 +524,6 @@ static int e1000e_post_load(void *opaque, int version_id)
E1000EState *s = opaque;
trace_e1000e_cb_post_load();
-
return e1000e_core_post_load(&s->core);
}
@@ -596,7 +595,7 @@ static const VMStateDescription e1000e_vmstate = {
VMSTATE_UINT32(core.delayed_causes, E1000EState),
VMSTATE_UINT16(subsys, E1000EState),
- VMSTATE_UINT16(subsys_ven, E1000EState),
+ VMSTATE_UINT16(subsys_vendor, E1000EState),
VMSTATE_E1000E_INTR_DELAY_TIMER(core.rdtr, E1000EState),
VMSTATE_E1000E_INTR_DELAY_TIMER(core.radv, E1000EState),
@@ -627,7 +626,7 @@ static const VMStateDescription e1000e_vmstate = {
static Property e1000e_properties[] = {
DEFINE_NIC_PROPERTIES(E1000EState, conf),
DEFINE_PROP_BOOL("vnet", E1000EState, has_vnet, true),
- DEFINE_PROP_UINT16("subsys_ven", E1000EState, subsys_ven, PCI_VENDOR_ID_INTEL),
+ DEFINE_PROP_UINT16("subsys-vendor", E1000EState, subsys_vendor, PCI_VENDOR_ID_INTEL),
DEFINE_PROP_UINT16("subsys", E1000EState, subsys, 0),
DEFINE_PROP_END_OF_LIST(),
};
--
2.7.4
next prev parent reply other threads:[~2016-10-26 19:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 19:21 [Qemu-devel] [PATCH 0/4] e1000e: QOM property & configuration cleanups Eduardo Habkost
2016-10-26 19:21 ` [Qemu-devel] [PATCH 1/4] e1000e: Use regular DEFINE_PROP_<type> macros for properties Eduardo Habkost
2016-10-27 3:12 ` Jason Wang
2016-10-27 6:38 ` Dmitry Fleytman
2016-10-27 11:25 ` Eduardo Habkost
2016-10-27 15:13 ` Igor Mammedov
2016-10-27 16:39 ` Eduardo Habkost
2016-10-26 19:21 ` [Qemu-devel] [PATCH 2/4] e1000e: No need to validate configuration on migration Eduardo Habkost
2016-10-27 6:42 ` Dmitry Fleytman
2016-10-27 11:39 ` Eduardo Habkost
2016-10-27 12:22 ` Dr. David Alan Gilbert
2016-10-27 14:28 ` Eduardo Habkost
2016-10-26 19:21 ` [Qemu-devel] [PATCH 3/4] e1000e: Rename "disable_vnet_hdr" property to "vnet" Eduardo Habkost
2016-10-27 6:47 ` Dmitry Fleytman
2016-10-26 19:21 ` Eduardo Habkost [this message]
2016-10-27 6:45 ` [Qemu-devel] [PATCH 4/4] e1000e: Rename "subsys_ven" property to "subsys-vendor" Dmitry Fleytman
2016-10-27 11:30 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477509718-6969-5-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).