From: Gerd Hoffmann <kraxel@redhat.com>
To: G 3 <programmingkidx@gmail.com>
Cc: qemu-devel qemu-devel <qemu-devel@nongnu.org>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99
Date: Thu, 27 Oct 2016 17:07:47 +0200 [thread overview]
Message-ID: <1477580867.9075.24.camel@redhat.com> (raw)
In-Reply-To: <4B74416B-EEBE-408F-B589-41318045938D@gmail.com>
> > +# needed to make gcc accept wide unicode chars without warning
> > +curses.o-cflags := -std=gnu99
> Could we add a commit message to this patch? It could answer
> questions like:
>
> Why this patch is needed?
> Who needs this patch?
> What problem it solves.
The comment added by the patch explains things.
I could cut+paste that into the commit msg, but given how small the
patch is it looked pointless to me ...
cheers,
Gerd
next prev parent reply other threads:[~2016-10-27 15:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.13406.1477569887.22738.qemu-devel@nongnu.org>
2016-10-27 14:51 ` [Qemu-devel] [PATCH] curses: build with -std=gnu99 G 3
2016-10-27 15:07 ` Gerd Hoffmann [this message]
2016-10-27 15:12 ` G 3
2016-10-27 11:46 Gerd Hoffmann
2016-10-27 15:04 ` Peter Maydell
2016-10-27 15:55 ` Gerd Hoffmann
2016-10-27 15:58 ` Samuel Thibault
2016-10-27 16:14 ` Peter Maydell
2016-10-27 16:36 ` Samuel Thibault
2016-10-27 16:52 ` Peter Maydell
2016-10-27 17:02 ` Samuel Thibault
2016-10-28 6:51 ` Markus Armbruster
2016-10-28 7:40 ` Samuel Thibault
2016-10-28 8:37 ` Markus Armbruster
2016-10-28 9:45 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477580867.9075.24.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).