From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, xiecl.fnst@cn.fujitsu.com,
wency@cn.fujitsu.com, pbonzini@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/7] blockjobs: preliminary refactoring work, Pt 1
Date: Thu, 27 Oct 2016 12:06:54 -0400 [thread overview]
Message-ID: <1477584421-1399-1-git-send-email-jsnow@redhat.com> (raw)
This is a follow-up to patches 2-6 of:
[PATCH v2 00/11] blockjobs: Fix transactional race condition
That series started trying to refactor blockjobs with the goal of
internalizing BlockJob state as a side effect of having gone through
the effort of figuring out which commands were "safe" to call on
a Job that has no coroutine object.
I've split out the less contentious bits so I can move forward with my
original work of focusing on the transactional race condition in a
different series.
Functionally the biggest difference here is the presence of "internal"
block jobs, which do not emit QMP events or show up in block query
requests. This is done for the sake of replication jobs, which should
not be interfering with the public jobs namespace.
===
v2
===
01: Cleaned up error message, fixed strcmp oversight, added assert()
02-07: Added R-Bs. (Does everyone else pronounce this as "Arby's" too?)
________________________________________________________________________________
For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch job-refactor-pt1
https://github.com/jnsnow/qemu/tree/job-refactor-pt1
This version is tagged job-refactor-pt1-v2:
https://github.com/jnsnow/qemu/releases/tag/job-refactor-pt1-v2
John Snow (7):
blockjobs: hide internal jobs from management API
blockjobs: Allow creating internal jobs
Replication/Blockjobs: Create replication jobs as internal
blockjob: centralize QMP event emissions
Blockjobs: Internalize user_pause logic
blockjobs: split interface into public/private, Part 1
blockjobs: fix documentation
block/backup.c | 5 +-
block/commit.c | 10 +-
block/mirror.c | 28 +++--
block/replication.c | 14 +--
block/stream.c | 9 +-
block/trace-events | 5 +-
blockdev.c | 74 +++++--------
blockjob.c | 113 +++++++++++++++----
include/block/block.h | 3 +-
include/block/block_int.h | 26 ++---
include/block/blockjob.h | 257 +++++++------------------------------------
include/block/blockjob_int.h | 232 ++++++++++++++++++++++++++++++++++++++
qemu-img.c | 5 +-
tests/test-blockjob-txn.c | 5 +-
tests/test-blockjob.c | 4 +-
15 files changed, 446 insertions(+), 344 deletions(-)
create mode 100644 include/block/blockjob_int.h
--
2.7.4
next reply other threads:[~2016-10-27 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 16:06 John Snow [this message]
2016-10-27 16:06 ` [Qemu-devel] [PATCH v2 1/7] blockjobs: hide internal jobs from management API John Snow
2016-10-27 16:06 ` [Qemu-devel] [PATCH v2 2/7] blockjobs: Allow creating internal jobs John Snow
2016-10-27 16:06 ` [Qemu-devel] [PATCH v2 3/7] Replication/Blockjobs: Create replication jobs as internal John Snow
2016-10-27 16:06 ` [Qemu-devel] [PATCH v2 4/7] blockjob: centralize QMP event emissions John Snow
2016-10-27 16:06 ` [Qemu-devel] [PATCH v2 5/7] Blockjobs: Internalize user_pause logic John Snow
2016-10-27 16:07 ` [Qemu-devel] [PATCH v2 6/7] blockjobs: split interface into public/private, Part 1 John Snow
2016-10-27 16:07 ` [Qemu-devel] [PATCH v2 7/7] blockjobs: fix documentation John Snow
2016-10-28 18:51 ` [Qemu-devel] [PATCH v2 0/7] blockjobs: preliminary refactoring work, Pt 1 Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477584421-1399-1-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wency@cn.fujitsu.com \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).