From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzp7K-0006oT-G5 for qemu-devel@nongnu.org; Thu, 27 Oct 2016 14:09:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzp7G-0006JW-4w for qemu-devel@nongnu.org; Thu, 27 Oct 2016 14:09:30 -0400 From: Kevin Wolf Date: Thu, 27 Oct 2016 20:08:54 +0200 Message-Id: <1477591747-21962-11-git-send-email-kwolf@redhat.com> In-Reply-To: <1477591747-21962-1-git-send-email-kwolf@redhat.com> References: <1477591747-21962-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 10/23] qemu-iotests: Fix typo for NFS with IMGOPTSSYNTAX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org Commit 076003f5 added configuration for NFS with IMGOPTSSYNTAX enabled, but it didn't use the right variable name: $TEST_DIR_OPTS doesn't exist. This fixes the mistake. However, this doesn't make anything work that was broken before: The only way to get IMGOPTSSYNTAX is with -luks, but the combination of -luks and -nfs doesn't get qemu-img create commands right (because qemu-img create doesn't support --image-opts yet), so even after this fix some more work would be required to make the tests pass. Reported-by: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 126bd67..3213765 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -69,7 +69,7 @@ if [ "$IMGOPTSSYNTAX" =3D "true" ]; then TEST_IMG=3D"$DRIVER,file.driver=3Dssh,file.host=3D127.0.0.1,file= .path=3D$TEST_IMG_FILE" elif [ "$IMGPROTO" =3D "nfs" ]; then TEST_DIR=3D"$DRIVER,file.driver=3Dnfs,file.filename=3Dnfs://127.= 0.0.1/$TEST_DIR" - TEST_IMG=3D$TEST_DIR_OPTS/t.$IMGFMT + TEST_IMG=3D$TEST_DIR/t.$IMGFMT elif [ "$IMGPROTO" =3D "archipelago" ]; then TEST_IMG=3D"$DRIVER,file.driver=3Darchipelago,file.volume=3D:at.= $IMGFMT" else --=20 1.8.3.1