qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [PULL 7/7] 9pfs: drop excessive error message from virtfs_reset()
Date: Sun, 30 Oct 2016 13:34:28 +0100	[thread overview]
Message-ID: <1477830868-12274-8-git-send-email-groug@kaod.org> (raw)
In-Reply-To: <1477830868-12274-1-git-send-email-groug@kaod.org>

The virtfs_reset() function is called either when the virtio-9p device
gets reset, or when the client starts a new 9P session. In both cases,
if it finds fids from a previous session, the following is printed in
the monitor:

9pfs:virtfs_reset: One or more uncluncked fids found during reset

For example, if a linux guest with a mounted 9P share is reset from the
monitor with system_reset, the message will be printed. This is excessive
since these fids are now clunked and the state is clean.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 hw/9pfs/9p.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 1050b89ec720..aea7e9d39206 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -535,7 +535,7 @@ static int coroutine_fn v9fs_mark_fids_unreclaim(V9fsPDU *pdu, V9fsPath *path)
 static void coroutine_fn virtfs_reset(V9fsPDU *pdu)
 {
     V9fsState *s = pdu->s;
-    V9fsFidState *fidp = NULL;
+    V9fsFidState *fidp;
 
     /* Free all fids */
     while (s->fid_list) {
@@ -548,11 +548,6 @@ static void coroutine_fn virtfs_reset(V9fsPDU *pdu)
             free_fid(pdu, fidp);
         }
     }
-    if (fidp) {
-        /* One or more unclunked fids found... */
-        error_report("9pfs:%s: One or more uncluncked fids "
-                     "found during reset", __func__);
-    }
 }
 
 #define P9_QID_TYPE_DIR         0x80
-- 
2.5.5

  parent reply	other threads:[~2016-10-30 12:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-30 12:34 [Qemu-devel] [PULL 0/7] 9p patches for 2.8 20161030 Greg Kurz
2016-10-30 12:34 ` [Qemu-devel] [PULL 1/7] 9pfs: add xattrwalk_fid field in V9fsXattr struct Greg Kurz
2016-10-30 12:34 ` [Qemu-devel] [PULL 2/7] 9pfs: convert 'len/copied_len' field in V9fsXattr to the type of uint64_t Greg Kurz
2016-10-30 12:34 ` [Qemu-devel] [PULL 3/7] 9pfs: fix integer overflow issue in xattr read/write Greg Kurz
2016-10-30 12:34 ` [Qemu-devel] [PULL 4/7] 9pfs: limit xattr size in xattrcreate Greg Kurz
2016-10-30 12:34 ` [Qemu-devel] [PULL 5/7] 9pfs: xattrcreate requires non-opened fids Greg Kurz
2016-10-30 12:34 ` [Qemu-devel] [PULL 6/7] 9pfs: don't BUG_ON() if fid is already opened Greg Kurz
2016-10-30 12:34 ` Greg Kurz [this message]
2016-10-31 14:48 ` [Qemu-devel] [PULL 0/7] 9p patches for 2.8 20161030 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477830868-12274-8-git-send-email-groug@kaod.org \
    --to=groug@kaod.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).