From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1Etq-0001mv-J0 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 11:53:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1Etn-0000r9-Hk for qemu-devel@nongnu.org; Mon, 31 Oct 2016 11:53:26 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:33414) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1Etn-0000qx-EZ for qemu-devel@nongnu.org; Mon, 31 Oct 2016 11:53:23 -0400 Received: by mail-qk0-x243.google.com with SMTP id x190so3335082qkb.0 for ; Mon, 31 Oct 2016 08:53:23 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Mon, 31 Oct 2016 09:52:52 -0600 Message-Id: <1477929173-2006-15-git-send-email-rth@twiddle.net> In-Reply-To: <1477929173-2006-1-git-send-email-rth@twiddle.net> References: <1477929173-2006-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PULL for-2.8 14/15] target-sparc: Use tcg_gen_atomic_xchg_tl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Tested-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target-sparc/translate.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index a123c0b..4c0346c 100644 --- a/target-sparc/translate.c +++ b/target-sparc/translate.c @@ -2026,27 +2026,16 @@ static inline void gen_ne_fop_QD(DisasContext *dc, int rd, int rs, static void gen_swap(DisasContext *dc, TCGv dst, TCGv src, TCGv addr, int mmu_idx, TCGMemOp memop) { - /* ??? Should be atomic. */ - TCGv t0 = tcg_temp_new(); gen_address_mask(dc, addr); - tcg_gen_qemu_ld_tl(t0, addr, mmu_idx, memop); - tcg_gen_qemu_st_tl(src, addr, mmu_idx, memop); - tcg_gen_mov_tl(dst, t0); - tcg_temp_free(t0); + tcg_gen_atomic_xchg_tl(dst, addr, src, mmu_idx, memop); } static void gen_ldstub(DisasContext *dc, TCGv dst, TCGv addr, int mmu_idx) { - /* ??? Should be atomic. */ - TCGv_i32 t0 = tcg_temp_new_i32(); - TCGv_i32 t1 = tcg_const_i32(0xff); - + TCGv m1 = tcg_const_tl(0xff); gen_address_mask(dc, addr); - tcg_gen_qemu_ld_i32(t0, addr, mmu_idx, MO_UB); - tcg_gen_qemu_st_i32(t1, addr, mmu_idx, MO_UB); - tcg_gen_extu_i32_tl(dst, t0); - tcg_temp_free_i32(t0); - tcg_temp_free_i32(t1); + tcg_gen_atomic_xchg_tl(dst, addr, m1, mmu_idx, MO_UB); + tcg_temp_free(m1); } /* asi moves */ -- 2.7.4