From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50247)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1c1Vud-0001u6-R2
	for qemu-devel@nongnu.org; Tue, 01 Nov 2016 06:03:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1c1Vua-0001Yn-JK
	for qemu-devel@nongnu.org; Tue, 01 Nov 2016 06:03:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60312)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <kraxel@redhat.com>) id 1c1Vua-0001YW-Df
	for qemu-devel@nongnu.org; Tue, 01 Nov 2016 06:03:20 -0400
Message-ID: <1477994598.26731.22.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 01 Nov 2016 11:03:18 +0100
In-Reply-To: <20161030152404.GY3671@var.home>
References: <20161023195433.20102-1-samuel.thibault@ens-lyon.org>
	<20161023195433.20102-4-samuel.thibault@ens-lyon.org>
	<1477477064.18984.39.camel@redhat.com> <20161030152404.GY3671@var.home>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum
 driver to graphical backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: qemu-devel@nongnu.org

  Hi,

> typedef void QemuConsoleConfigListener(void);

I think we should also pass the console which has changed:=20

QemuConsoleConfigListener(QemuConsole *con);

> qemu_console_config_add_listener(QemuConsoleConfigListener listener);
> qemu_console_config_remove_listener(QemuConsoleConfigListener listener);

Otherwise this approach looks good to me.

cheers,
  Gerd