From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1W2f-0004Ck-0X for qemu-devel@nongnu.org; Tue, 01 Nov 2016 06:11:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1W2a-0003si-34 for qemu-devel@nongnu.org; Tue, 01 Nov 2016 06:11:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34430) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1W2Z-0003sb-US for qemu-devel@nongnu.org; Tue, 01 Nov 2016 06:11:36 -0400 Message-ID: <1477995092.26731.28.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 01 Nov 2016 11:11:32 +0100 In-Reply-To: <20161031160007.6047-2-samuel.thibault@ens-lyon.org> References: <20161031160007.6047-1-samuel.thibault@ens-lyon.org> <20161031160007.6047-2-samuel.thibault@ens-lyon.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/4] console: add API to get underlying gui window ID List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: qemu-devel@nongnu.org > int qemu_console_get_width(QemuConsole *con, int fallback); > int qemu_console_get_height(QemuConsole *con, int fallback); > +/* Return the low-level window id for the first graphical console */ > +int qemu_graphic_console_get_window_id(void); > +void qemu_console_set_window_id(int index, int window_id); Both qemu_console_{set,get}_window_id should have a QemuConsole *con argument, like the other ones. There is also no reason to limit this interface to graphic consoles. baum.c can use qemu_console_lookup_by_index() and qemu_console_is_graphic() to implement this logic (sorry, missed this on the first review). cheers, Gerd