From: Jeff Cody <jcody@redhat.com>
To: qemu-block@nongnu.org
Cc: peter.maydell@linaro.org, jcody@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL v2 07/14] block/gluster: fix port type in the QAPI options list
Date: Tue, 1 Nov 2016 08:51:04 -0400 [thread overview]
Message-ID: <1478004671-19154-8-git-send-email-jcody@redhat.com> (raw)
In-Reply-To: <1478004671-19154-1-git-send-email-jcody@redhat.com>
From: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
After introduction of qapi schema in gluster block driver code, the port
type is now string as per InetSocketAddress
{ 'struct': 'InetSocketAddress',
'data': {
'host': 'str',
'port': 'str',
'*to': 'uint16',
'*ipv4': 'bool',
'*ipv6': 'bool' } }
but the current code still treats it as QEMU_OPT_NUMBER, hence fixing port
to accept QEMU_OPT_STRING.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
block/gluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/gluster.c b/block/gluster.c
index 98a9132..0ce15f7 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -186,7 +186,7 @@ static QemuOptsList runtime_tcp_opts = {
},
{
.name = GLUSTER_OPT_PORT,
- .type = QEMU_OPT_NUMBER,
+ .type = QEMU_OPT_STRING,
.help = "port number on which glusterd is listening (default 24007)",
},
{
--
2.7.4
next prev parent reply other threads:[~2016-11-01 12:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 12:50 [Qemu-devel] [PULL v2 00/14] Block patches for 2.8 Jeff Cody
2016-11-01 12:50 ` [Qemu-devel] [PULL v2 01/14] qapi: add release designator to gluster logfile option Jeff Cody
2016-11-01 12:50 ` [Qemu-devel] [PULL v2 02/14] rbd: make the code more readable Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 03/14] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 04/14] block/gluster: memory usage: use one glfs instance per volume Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 05/14] block: Turn on "unmap" in active commit Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 06/14] block/gluster: improve defense over string to int conversion Jeff Cody
2016-11-01 12:51 ` Jeff Cody [this message]
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 08/14] blockjobs: hide internal jobs from management API Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 09/14] blockjobs: Allow creating internal jobs Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 10/14] Replication/Blockjobs: Create replication jobs as internal Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 11/14] blockjob: centralize QMP event emissions Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 12/14] Blockjobs: Internalize user_pause logic Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 13/14] blockjobs: split interface into public/private, Part 1 Jeff Cody
2016-11-01 12:51 ` [Qemu-devel] [PULL v2 14/14] blockjobs: fix documentation Jeff Cody
2016-11-01 13:12 ` [Qemu-devel] [PULL v2 00/14] Block patches for 2.8 no-reply
2016-11-01 15:15 ` Peter Maydell
2016-11-02 17:03 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-11-02 18:11 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478004671-19154-8-git-send-email-jcody@redhat.com \
--to=jcody@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).