From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1bOC-00066w-Sd for qemu-devel@nongnu.org; Tue, 01 Nov 2016 11:54:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1bO8-00040M-1k for qemu-devel@nongnu.org; Tue, 01 Nov 2016 11:54:16 -0400 Received: from mail-by2nam01on0048.outbound.protection.outlook.com ([104.47.34.48]:28325 helo=NAM01-BY2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1bO7-000405-PG for qemu-devel@nongnu.org; Tue, 01 Nov 2016 11:54:11 -0400 From: Brijesh Singh Date: Tue, 1 Nov 2016 11:54:06 -0400 Message-ID: <147801564680.18237.14482964919097131701.stgit@brijesh-build-machine> In-Reply-To: <147801550845.18237.12915616525154608660.stgit@brijesh-build-machine> References: <147801550845.18237.12915616525154608660.stgit@brijesh-build-machine> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RFC PATCH v3 13/18] sev: add DEBUG_DECRYPT command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas.Lendacky@amd.com, ehabkost@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, mst@redhat.com, p.fedin@samsung.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, rth@twiddle.net Cc: brijesh.ksingh@gmail.com The command is used to decrypt a page of guest memory for debug. The command will be used by qemu monitor dump and gdbserver to access the guest memory for debug purposes. A typical usage look like: cpu_physical_memory_rw_debug cpu_physical_memory_rw_debug_internal sev_debug_decrypt Signed-off-by: Brijesh Singh --- sev.c | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/sev.c b/sev.c index ff9266a..f690a86 100644 --- a/sev.c +++ b/sev.c @@ -329,6 +329,28 @@ err: } static int +sev_debug_decrypt(SEVState *s, uint8_t *dst, const uint8_t *src, uint32_t len) +{ + int ret; + struct kvm_sev_dbg_decrypt *dbg; + + dbg = g_malloc0(sizeof(*dbg)); + if (!dbg) { + return 1; + } + + dbg->src_addr = (unsigned long)src; + dbg->dst_addr = (unsigned long)dst; + dbg->length = len; + + ret = sev_ioctl(KVM_SEV_DBG_DECRYPT, dbg); + DPRINTF("SEV: DBG_DECRYPT src %#lx dst %#lx len %#x\n", + (uint64_t)src, (uint64_t)dst, len); + g_free(dbg); + return ret; +} + +static int sev_mem_write(uint8_t *dst, const uint8_t *src, uint32_t len, MemTxAttrs attrs) { SEVState *s = kvm_memory_encryption_get_handle(); @@ -348,9 +370,9 @@ sev_mem_read(uint8_t *dst, const uint8_t *src, uint32_t len, MemTxAttrs attrs) { SEVState *s = kvm_memory_encryption_get_handle(); - assert(s != NULL && s->state != SEV_STATE_INVALID); + assert(attrs.debug || (s != NULL && s->state != SEV_STATE_INVALID)); - return 0; + return sev_debug_decrypt(s, dst, src, len); } static int @@ -453,7 +475,7 @@ sev_guest_mem_dec(void *handle, uint8_t *dst, const uint8_t *src, uint32_t len) assert(s != NULL && s->state != SEV_STATE_INVALID); /* use SEV debug command to decrypt memory */ - return 1; + return sev_debug_decrypt((SEVState *)handle, dst, src, len); } int