qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: brijesh.singh@amd.com
Cc: famz@redhat.com, Thomas.Lendacky@amd.com, ehabkost@redhat.com,
	crosthwaite.peter@gmail.com, armbru@redhat.com, mst@redhat.com,
	p.fedin@samsung.com, qemu-devel@nongnu.org,
	lcapitulino@redhat.com, pbonzini@redhat.com, rth@twiddle.net,
	brijesh.ksingh@gmail.com
Subject: Re: [Qemu-devel] [RFC PATCH v3 00/18] x86: Secure Encrypted Virtualization (AMD)
Date: Tue, 1 Nov 2016 09:22:20 -0700 (PDT)	[thread overview]
Message-ID: <147801733842.190.273030864722303449@9040ca97f87d> (raw)
In-Reply-To: <147801550845.18237.12915616525154608660.stgit@brijesh-build-machine>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [RFC PATCH v3 00/18] x86: Secure Encrypted Virtualization (AMD)
Message-id: 147801550845.18237.12915616525154608660.stgit@brijesh-build-machine

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/147801550845.18237.12915616525154608660.stgit@brijesh-build-machine -> patchew/147801550845.18237.12915616525154608660.stgit@brijesh-build-machine
Switched to a new branch 'test'
c628575 migration: disable save/restore and migration on SEV guest
bcc9622 i386: clear C-bit in SEV guest page table walk
13f1aec target-i386: add cpuid Fn8000_001f
e32e371 i386: register memory encryption ops
23d4ae8 sev: add DEBUG_ENCRYPT command
73d2734 sev: add DEBUG_DECRYPT command
ec4a4f5 sev: add LAUNCH_FINISH command
07766c2 sev: add LAUNCH_UPDATE command
60727f5 sev: add LAUNCH_START command
7fba3df core: loader: create memory encryption context before copying data
54a514a hmp: display memory encryption support in 'info kvm'
38fa75b sev: add Secure Encrypted Virtulization (SEV) support
54afe9f kvm: add memory encryption APIs
4c505a9 core: add new security-policy object
a2865ab monitor: use debug version of memory access apis
7725400 exec: add debug version of physical memory read and write apis
01aff50 exec: add guest RAM read and write ops
69f6122 memattrs: add debug attrs

=== OUTPUT BEGIN ===
fatal: unrecognized argument: --no-patch
Checking PATCH 1/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 2/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 3/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 4/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 5/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 6/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 7/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 8/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 9/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 10/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 11/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 12/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 13/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 14/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 15/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 16/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 17/18: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 18/18: ...
ERROR: Error messages should not contain newlines
#31: FILE: migration/migration.c:1156:
+        error_setg(errp, "Migration is not implemented on SEV guest\n");

ERROR: Error messages should not contain newlines
#67: FILE: migration/savevm.c:2186:
+        error_report("loadvm is not implemented on SEV guest\n");

total: 2 errors, 0 warnings, 48 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  parent reply	other threads:[~2016-11-01 16:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01 15:51 [Qemu-devel] [RFC PATCH v3 00/18] x86: Secure Encrypted Virtualization (AMD) Brijesh Singh
2016-11-01 15:51 ` [Qemu-devel] [RFC PATCH v3 01/18] memattrs: add debug attrs Brijesh Singh
2016-11-01 15:52 ` [Qemu-devel] [RFC PATCH v3 02/18] exec: add guest RAM read and write ops Brijesh Singh
2016-11-01 15:52 ` [Qemu-devel] [RFC PATCH v3 03/18] exec: add debug version of physical memory read and write apis Brijesh Singh
2016-11-01 15:52 ` [Qemu-devel] [RFC PATCH v3 04/18] monitor: use debug version of memory access apis Brijesh Singh
2016-11-01 15:52 ` [Qemu-devel] [RFC PATCH v3 05/18] core: add new security-policy object Brijesh Singh
2016-11-01 15:52 ` [Qemu-devel] [RFC PATCH v3 06/18] kvm: add memory encryption APIs Brijesh Singh
2016-11-01 15:53 ` [Qemu-devel] [RFC PATCH v3 07/18] sev: add Secure Encrypted Virtulization (SEV) support Brijesh Singh
2016-11-01 15:53 ` [Qemu-devel] [RFC PATCH v3 08/18] hmp: display memory encryption support in 'info kvm' Brijesh Singh
2016-11-01 15:53 ` [Qemu-devel] [RFC PATCH v3 09/18] core: loader: create memory encryption context before copying data Brijesh Singh
2016-11-01 15:53 ` [Qemu-devel] [RFC PATCH v3 10/18] sev: add LAUNCH_START command Brijesh Singh
2016-11-01 15:53 ` [Qemu-devel] [RFC PATCH v3 11/18] sev: add LAUNCH_UPDATE command Brijesh Singh
2016-11-01 15:53 ` [Qemu-devel] [RFC PATCH v3 12/18] sev: add LAUNCH_FINISH command Brijesh Singh
2016-11-01 15:54 ` [Qemu-devel] [RFC PATCH v3 13/18] sev: add DEBUG_DECRYPT command Brijesh Singh
2016-11-01 15:54 ` [Qemu-devel] [RFC PATCH v3 14/18] sev: add DEBUG_ENCRYPT command Brijesh Singh
2016-11-01 15:54 ` [Qemu-devel] [RFC PATCH v3 15/18] i386: register memory encryption ops Brijesh Singh
2016-11-01 15:54 ` [Qemu-devel] [RFC PATCH v3 16/18] target-i386: add cpuid Fn8000_001f Brijesh Singh
2016-11-01 15:54 ` [Qemu-devel] [RFC PATCH v3 17/18] i386: clear C-bit in SEV guest page table walk Brijesh Singh
2016-11-01 15:54 ` [Qemu-devel] [RFC PATCH v3 18/18] migration: disable save/restore and migration on SEV guest Brijesh Singh
2016-11-01 16:22 ` no-reply [this message]
2016-11-01 16:31   ` [Qemu-devel] [RFC PATCH v3 00/18] x86: Secure Encrypted Virtualization (AMD) Peter Maydell
2016-11-01 16:24 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=147801733842.190.273030864722303449@9040ca97f87d \
    --to=no-reply@patchew.org \
    --cc=Thomas.Lendacky@amd.com \
    --cc=armbru@redhat.com \
    --cc=brijesh.ksingh@gmail.com \
    --cc=brijesh.singh@amd.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mst@redhat.com \
    --cc=p.fedin@samsung.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).