qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: eblake@redhat.com, armbru@redhat.com
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
Date: Wed, 2 Nov 2016 15:44:12 +0800	[thread overview]
Message-ID: <1478072652-9884-1-git-send-email-zhang.zhanghailiang@huawei.com> (raw)

VM can not get into colo state unless users enable 'x-colo'
capability for migration, Here it is necessary to clarify
this.

Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
v2:
- Clarify colo state for RunState too as Eric suggested.
---
 qapi-schema.json | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index 5dc96af..04f5aab 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -176,8 +176,9 @@
 #
 # @guest-panicked: guest has been panicked as a result of guest OS panic
 #
-# @colo: guest is paused to save/restore VM state under colo checkpoint (since
-# 2.8)
+# @colo: guest is paused to save/restore VM state under colo checkpoint,
+#        VM can not get into this state unless colo capability is enabled
+#        for migration. (since 2.8)
 ##
 { 'enum': 'RunState',
   'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
@@ -462,7 +463,8 @@
 #
 # @failed: some error occurred during migration process.
 #
-# @colo: VM is in the process of fault tolerance. (since 2.8)
+# @colo: VM is in the process of fault tolerance, VM can not get into this
+#        state unless colo capability is enabled for migration. (since 2.8)
 #
 # Since: 2.3
 #
-- 
1.8.3.1

             reply	other threads:[~2016-11-02  7:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02  7:44 zhanghailiang [this message]
2016-11-02 14:04 ` [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus Eric Blake
2016-11-14  2:36   ` Hailiang Zhang
2016-11-14 13:54     ` Stefan Hajnoczi
2016-11-15  6:12       ` Hailiang Zhang
2016-11-15  8:44       ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2016-11-15  8:58         ` Zhang Chen
2016-11-15  9:03           ` Hailiang Zhang
2016-11-15  9:10             ` Zhang Chen
2016-11-17  7:08         ` Hailiang Zhang
2016-11-17  7:52           ` Laurent Vivier
2016-11-17 10:07             ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478072652-9884-1-git-send-email-zhang.zhanghailiang@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).