From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1sCr-0006sW-N7 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:51:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1sCm-0004XR-QZ for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:51:41 -0400 From: Ashijeet Acharya Date: Wed, 2 Nov 2016 15:18:40 +0530 Message-Id: <1478080120-3277-1-git-send-email-ashijeetacharya@gmail.com> Subject: [Qemu-devel] [PATCH v2] block/nbd: Fix the regression to free leaked visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com Cc: mreitz@redhat.com, pbonzini@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, Ashijeet Acharya This patch frees the leaked visitor in nbd_refresh_filename() and uses visit_free() to fix it. The leak was introduced by the commit 491d6c7. Signed-off-by: Ashijeet Acharya Reviewed-by: Eric Blake --- Changes in v2: - Include the regression commit id in the commit message --- block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nbd.c b/block/nbd.c index 8ef1438..ff9d01a 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -545,6 +545,7 @@ static void nbd_refresh_filename(BlockDriverState *bs, QDict *options) qdict_put(opts, "tls-creds", qstring_from_str(s->tlscredsid)); } + visit_free(ov); qdict_flatten(opts); bs->full_open_options = opts; } -- 2.6.2