* [Qemu-devel] [PATCH] target-i386: fix typo
@ 2016-11-02 19:58 Paolo Bonzini
2016-11-04 16:20 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2016-11-02 19:58 UTC (permalink / raw)
To: qemu-devel
The impact is small because kvm_get_vcpu_events fixes env->hflags, but
it is wrong and could cause INITs to be delayed arbitrarily with
-machine kernel_irqchip=off.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target-i386/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 1c0864e..f62264a 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -2855,7 +2855,7 @@ MemTxAttrs kvm_arch_post_run(CPUState *cpu, struct kvm_run *run)
if (run->flags & KVM_RUN_X86_SMM) {
env->hflags |= HF_SMM_MASK;
} else {
- env->hflags &= HF_SMM_MASK;
+ env->hflags &= ~HF_SMM_MASK;
}
if (run->if_flag) {
env->eflags |= IF_MASK;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-i386: fix typo
2016-11-02 19:58 [Qemu-devel] [PATCH] target-i386: fix typo Paolo Bonzini
@ 2016-11-04 16:20 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2016-11-04 16:20 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 11/02/2016 01:58 PM, Paolo Bonzini wrote:
> The impact is small because kvm_get_vcpu_events fixes env->hflags, but
> it is wrong and could cause INITs to be delayed arbitrarily with
> -machine kernel_irqchip=off.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target-i386/kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-04 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-02 19:58 [Qemu-devel] [PATCH] target-i386: fix typo Paolo Bonzini
2016-11-04 16:20 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).