From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c21gH-0004H5-0L for qemu-devel@nongnu.org; Wed, 02 Nov 2016 15:58:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c21gE-0000nd-0W for qemu-devel@nongnu.org; Wed, 02 Nov 2016 15:58:41 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:33378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c21gD-0000nI-Pw for qemu-devel@nongnu.org; Wed, 02 Nov 2016 15:58:37 -0400 Received: by mail-wm0-x244.google.com with SMTP id u144so4667398wmu.0 for ; Wed, 02 Nov 2016 12:58:37 -0700 (PDT) Received: from localhost.localdomain (89-96-140-183.ip12.fastwebnet.it. [89.96.140.183]) by smtp.gmail.com with ESMTPSA id 135sm5077970wmq.8.2016.11.02.12.58.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Nov 2016 12:58:35 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 2 Nov 2016 20:58:34 +0100 Message-Id: <1478116714-28207-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] target-i386: fix typo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The impact is small because kvm_get_vcpu_events fixes env->hflags, but it is wrong and could cause INITs to be delayed arbitrarily with -machine kernel_irqchip=off. Signed-off-by: Paolo Bonzini --- target-i386/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 1c0864e..f62264a 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -2855,7 +2855,7 @@ MemTxAttrs kvm_arch_post_run(CPUState *cpu, struct kvm_run *run) if (run->flags & KVM_RUN_X86_SMM) { env->hflags |= HF_SMM_MASK; } else { - env->hflags &= HF_SMM_MASK; + env->hflags &= ~HF_SMM_MASK; } if (run->if_flag) { env->eflags |= IF_MASK; -- 2.7.4