qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>, dgilbert@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] virtio-net: spec compatibility fix
Date: Fri, 4 Nov 2016 13:01:30 +0200	[thread overview]
Message-ID: <1478257275-30365-1-git-send-email-mst@redhat.com> (raw)

Virtio 1.0 spec lists VIRTIO_NET_F_GSO as a legacy-only flag,
by mistake we exposed it on the modern interface too, this
is a spec violation.

I decided it's not worth it to implement a compatibility bit here as we already
shipped virtio 1.0 support, we want to fix compatibility for old machine types
too.  While changing feature bits under guest's feet might be surprising, the
spec doesn't exactly say it's illegal.

Michael S. Tsirkin (2):
  virtio: allow per-device-class legacy features
  virtio-net: mark VIRTIO_NET_F_GSO as legacy

 include/hw/virtio/virtio.h | 5 +++++
 hw/net/virtio-net.c        | 1 +
 hw/s390x/virtio-ccw.c      | 4 +++-
 hw/virtio/virtio-pci.c     | 4 +++-
 hw/virtio/virtio.c         | 2 ++
 5 files changed, 14 insertions(+), 2 deletions(-)

-- 
MST

             reply	other threads:[~2016-11-04 11:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 11:01 Michael S. Tsirkin [this message]
2016-11-04 11:01 ` [Qemu-devel] [PATCH 1/2] virtio: allow per-device-class legacy features Michael S. Tsirkin
2016-11-04 11:32   ` Cornelia Huck
2016-11-07  9:11   ` Jason Wang
2016-11-04 11:01 ` [Qemu-devel] [PATCH 2/2] virtio-net: mark VIRTIO_NET_F_GSO as legacy Michael S. Tsirkin
2016-11-04 11:37   ` Cornelia Huck
2016-11-07  9:11   ` Jason Wang
2016-11-07 15:38   ` Dr. David Alan Gilbert
2016-11-07 19:43     ` Halil Pasic
2016-11-07 19:25   ` Halil Pasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478257275-30365-1-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).