From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2cFj-0003rY-32 for qemu-devel@nongnu.org; Fri, 04 Nov 2016 07:01:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2cFg-0000DB-2G for qemu-devel@nongnu.org; Fri, 04 Nov 2016 07:01:43 -0400 Received: from mail.kernel.org ([198.145.29.136]:39720) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c2cFf-0000CF-SJ for qemu-devel@nongnu.org; Fri, 04 Nov 2016 07:01:39 -0400 Date: Fri, 4 Nov 2016 13:01:30 +0200 From: "Michael S. Tsirkin" Message-ID: <1478257275-30365-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH 0/2] virtio-net: spec compatibility fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jason Wang , dgilbert@redhat.com Virtio 1.0 spec lists VIRTIO_NET_F_GSO as a legacy-only flag, by mistake we exposed it on the modern interface too, this is a spec violation. I decided it's not worth it to implement a compatibility bit here as we already shipped virtio 1.0 support, we want to fix compatibility for old machine types too. While changing feature bits under guest's feet might be surprising, the spec doesn't exactly say it's illegal. Michael S. Tsirkin (2): virtio: allow per-device-class legacy features virtio-net: mark VIRTIO_NET_F_GSO as legacy include/hw/virtio/virtio.h | 5 +++++ hw/net/virtio-net.c | 1 + hw/s390x/virtio-ccw.c | 4 +++- hw/virtio/virtio-pci.c | 4 +++- hw/virtio/virtio.c | 2 ++ 5 files changed, 14 insertions(+), 2 deletions(-) -- MST