* [Qemu-devel] [PATCH for-2.8] nfs: Fix memory leak in nfs_file_create()
@ 2016-11-07 9:31 Kevin Wolf
2016-11-07 13:36 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2016-11-07 9:31 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, ashijeetacharya, pl, qemu-devel
The leak was introduced in commit 94d6a7a7.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/nfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nfs.c b/block/nfs.c
index 55c4e0b..d082783 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -676,6 +676,7 @@ static int nfs_file_create(const char *url, QemuOpts *opts, Error **errp)
ret = nfs_ftruncate(client->context, client->fh, total_size);
nfs_client_close(client);
out:
+ QDECREF(options);
g_free(client);
return ret;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] nfs: Fix memory leak in nfs_file_create()
2016-11-07 9:31 [Qemu-devel] [PATCH for-2.8] nfs: Fix memory leak in nfs_file_create() Kevin Wolf
@ 2016-11-07 13:36 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2016-11-07 13:36 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-block, pl, qemu-devel, ashijeetacharya
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
On Mon, Nov 07, 2016 at 10:31:29AM +0100, Kevin Wolf wrote:
> The leak was introduced in commit 94d6a7a7.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/nfs.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-07 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-07 9:31 [Qemu-devel] [PATCH for-2.8] nfs: Fix memory leak in nfs_file_create() Kevin Wolf
2016-11-07 13:36 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).