From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@gmail.com>
Subject: [Qemu-devel] [PULL 3/4] Fix corruption of CPSR when SCTLR.EE is set
Date: Mon, 7 Nov 2016 10:47:32 +0000 [thread overview]
Message-ID: <1478515653-6361-4-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1478515653-6361-1-git-send-email-peter.maydell@linaro.org>
From: Julian Brown <julian@codesourcery.com>
Fix a typo in arm_cpu_do_interrupt_aarch32 (OR'ing with ~CPSR_E
instead of CPSR_E) which meant that when we took an interrupt with
SCTLR.EE set we would corrupt the CPSR.
Signed-off-by: Julian Brown <julian@codesourcery.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-arm/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index 25b15dc..b5b65ca 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -6438,7 +6438,7 @@ static void arm_cpu_do_interrupt_aarch32(CPUState *cs)
/* Set new mode endianness */
env->uncached_cpsr &= ~CPSR_E;
if (env->cp15.sctlr_el[arm_current_el(env)] & SCTLR_EE) {
- env->uncached_cpsr |= ~CPSR_E;
+ env->uncached_cpsr |= CPSR_E;
}
env->daif |= mask;
/* this is a lie, as the was no c1_sys on V4T/V5, but who cares
--
2.7.4
next prev parent reply other threads:[~2016-11-07 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 10:47 [Qemu-devel] [PULL 0/4] target-arm queue Peter Maydell
2016-11-07 10:47 ` [Qemu-devel] [PULL 1/4] char: cadence: check baud rate generator and divider values Peter Maydell
2016-11-07 10:47 ` [Qemu-devel] [PULL 2/4] nvic: set pending status for not active interrupts Peter Maydell
2016-11-07 10:47 ` Peter Maydell [this message]
2016-11-07 10:47 ` [Qemu-devel] [PULL 4/4] hw/i2c/bitbang_i2c: Handle NACKs from devices Peter Maydell
2016-11-07 14:55 ` [Qemu-devel] [PULL 0/4] target-arm queue Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478515653-6361-4-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).