From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com,
mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
dan.j.williams@intel.com, kvm@vger.kernel.org,
qemu-devel@nongnu.org,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: [Qemu-devel] [PATCH 13/14] nvdimm acpi: use aml_name_decl to define named object
Date: Mon, 7 Nov 2016 19:13:48 +0800 [thread overview]
Message-ID: <1478517229-140028-14-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1478517229-140028-1-git-send-email-guangrong.xiao@linux.intel.com>
to make the code more clearer
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
hw/acpi/nvdimm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 6692648..5f48b75 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -1098,13 +1098,11 @@ static void nvdimm_build_fit(Aml *dev)
buf_size = aml_local(1);
fit = aml_local(2);
- aml_append(dev, aml_create_dword_field(aml_buffer(4, NULL),
- aml_int(0), NVDIMM_DSM_RFIT_STATUS));
+ aml_append(dev, aml_name_decl(NVDIMM_DSM_RFIT_STATUS, aml_int(0)));
/* build helper function, RFIT. */
method = aml_method("RFIT", 1, AML_SERIALIZED);
- aml_append(method, aml_create_dword_field(aml_buffer(4, NULL),
- aml_int(0), "OFST"));
+ aml_append(method, aml_name_decl("OFST", aml_int(0)));
/* prepare input package. */
pkg = aml_package(1);
--
1.8.3.1
next prev parent reply other threads:[~2016-11-07 11:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 11:13 [Qemu-devel] [PATCH 00/14] improve nvdimm hotplug Xiao Guangrong
2016-11-07 11:13 ` [Qemu-devel] [PATCH 01/14] qdev: hotplug: drop HotplugHandler.post_plug callback Xiao Guangrong
2016-11-07 15:30 ` Stefan Hajnoczi
2016-11-09 16:37 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 02/14] nvdimm acpi: drop the lock of fit buffer Xiao Guangrong
2016-11-07 15:30 ` Stefan Hajnoczi
2016-11-09 16:38 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 03/14] pc: memhp: move nvdimm hotplug out of memory hotplug Xiao Guangrong
2016-11-07 15:31 ` Stefan Hajnoczi
2016-11-09 16:38 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 04/14] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug Xiao Guangrong
2016-11-07 15:32 ` Stefan Hajnoczi
2016-11-09 16:38 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 05/14] nvdimm acpi: clean up nvdimm_build_acpi Xiao Guangrong
2016-11-07 15:32 ` Stefan Hajnoczi
2016-11-09 16:39 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 06/14] docs: improve the doc of Read FIT method Xiao Guangrong
2016-11-07 15:32 ` Stefan Hajnoczi
2016-11-09 16:39 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 07/14] nvdimm acpi: rename nvdimm_plugged_device_list Xiao Guangrong
2016-11-07 15:33 ` Stefan Hajnoczi
2016-11-09 16:39 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit Xiao Guangrong
2016-11-07 15:33 ` Stefan Hajnoczi
2016-11-09 16:40 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 09/14] nvdimm acpi: rename nvdimm_acpi_hotplug Xiao Guangrong
2016-11-07 15:33 ` Stefan Hajnoczi
2016-11-09 16:40 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 10/14] nvdimm acpi: define DSM return codes Xiao Guangrong
2016-11-07 15:34 ` Stefan Hajnoczi
2016-11-09 16:40 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 11/14] nvdimm acpi: fix two comments Xiao Guangrong
2016-11-07 15:34 ` Stefan Hajnoczi
2016-11-09 16:41 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 12/14] nvdimm acpi: rename nvdimm_dsm_reserved_root Xiao Guangrong
2016-11-07 15:34 ` Stefan Hajnoczi
2016-11-09 16:41 ` Igor Mammedov
2016-11-07 11:13 ` Xiao Guangrong [this message]
2016-11-07 15:34 ` [Qemu-devel] [PATCH 13/14] nvdimm acpi: use aml_name_decl to define named object Stefan Hajnoczi
2016-11-09 16:41 ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 14/14] nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE Xiao Guangrong
2016-11-07 15:35 ` Stefan Hajnoczi
2016-11-09 16:41 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478517229-140028-14-git-send-email-guangrong.xiao@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).