qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com,
	mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	dan.j.williams@intel.com, kvm@vger.kernel.org,
	qemu-devel@nongnu.org,
	Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: [Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit
Date: Mon,  7 Nov 2016 19:13:43 +0800	[thread overview]
Message-ID: <1478517229-140028-9-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1478517229-140028-1-git-send-email-guangrong.xiao@linux.intel.com>

inline buf_size to refine the code a bit

Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
 hw/acpi/nvdimm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index f2c0659..148999e 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -1134,11 +1134,9 @@ static void nvdimm_build_fit(Aml *dev)
     aml_append(ifctx, aml_return(aml_buffer(0, NULL)));
     aml_append(method, ifctx);
 
-    aml_append(method, aml_store(aml_shiftleft(buf_size, aml_int(3)),
-                                 buf_size));
     aml_append(method, aml_create_field(buf,
                             aml_int(4 * BITS_PER_BYTE), /* offset at byte 4.*/
-                            buf_size, "BUFF"));
+                            aml_shiftleft(buf_size, aml_int(3)), "BUFF"));
     aml_append(method, aml_return(aml_name("BUFF")));
     aml_append(dev, method);
 
-- 
1.8.3.1

  parent reply	other threads:[~2016-11-07 11:29 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 11:13 [Qemu-devel] [PATCH 00/14] improve nvdimm hotplug Xiao Guangrong
2016-11-07 11:13 ` [Qemu-devel] [PATCH 01/14] qdev: hotplug: drop HotplugHandler.post_plug callback Xiao Guangrong
2016-11-07 15:30   ` Stefan Hajnoczi
2016-11-09 16:37   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 02/14] nvdimm acpi: drop the lock of fit buffer Xiao Guangrong
2016-11-07 15:30   ` Stefan Hajnoczi
2016-11-09 16:38   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 03/14] pc: memhp: move nvdimm hotplug out of memory hotplug Xiao Guangrong
2016-11-07 15:31   ` Stefan Hajnoczi
2016-11-09 16:38   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 04/14] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug Xiao Guangrong
2016-11-07 15:32   ` Stefan Hajnoczi
2016-11-09 16:38   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 05/14] nvdimm acpi: clean up nvdimm_build_acpi Xiao Guangrong
2016-11-07 15:32   ` Stefan Hajnoczi
2016-11-09 16:39   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 06/14] docs: improve the doc of Read FIT method Xiao Guangrong
2016-11-07 15:32   ` Stefan Hajnoczi
2016-11-09 16:39   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 07/14] nvdimm acpi: rename nvdimm_plugged_device_list Xiao Guangrong
2016-11-07 15:33   ` Stefan Hajnoczi
2016-11-09 16:39   ` Igor Mammedov
2016-11-07 11:13 ` Xiao Guangrong [this message]
2016-11-07 15:33   ` [Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit Stefan Hajnoczi
2016-11-09 16:40   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 09/14] nvdimm acpi: rename nvdimm_acpi_hotplug Xiao Guangrong
2016-11-07 15:33   ` Stefan Hajnoczi
2016-11-09 16:40   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 10/14] nvdimm acpi: define DSM return codes Xiao Guangrong
2016-11-07 15:34   ` Stefan Hajnoczi
2016-11-09 16:40   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 11/14] nvdimm acpi: fix two comments Xiao Guangrong
2016-11-07 15:34   ` Stefan Hajnoczi
2016-11-09 16:41   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 12/14] nvdimm acpi: rename nvdimm_dsm_reserved_root Xiao Guangrong
2016-11-07 15:34   ` Stefan Hajnoczi
2016-11-09 16:41   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 13/14] nvdimm acpi: use aml_name_decl to define named object Xiao Guangrong
2016-11-07 15:34   ` Stefan Hajnoczi
2016-11-09 16:41   ` Igor Mammedov
2016-11-07 11:13 ` [Qemu-devel] [PATCH 14/14] nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE Xiao Guangrong
2016-11-07 15:35   ` Stefan Hajnoczi
2016-11-09 16:41   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478517229-140028-9-git-send-email-guangrong.xiao@linux.intel.com \
    --to=guangrong.xiao@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).