From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4Taw-0003r7-QG for qemu-devel@nongnu.org; Wed, 09 Nov 2016 09:11:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4Tat-0002yQ-8J for qemu-devel@nongnu.org; Wed, 09 Nov 2016 09:11:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37568) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4Tat-0002yF-3U for qemu-devel@nongnu.org; Wed, 09 Nov 2016 09:11:15 -0500 From: Gerd Hoffmann Date: Wed, 9 Nov 2016 14:33:31 +0100 Message-Id: <1478698412-4865-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1478698412-4865-1-git-send-email-kraxel@redhat.com> References: <1478698412-4865-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 2/2] usbredir: free vm_change_state_handler in usbredir destroy dispatch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Li Qiang , Gerd Hoffmann From: Li Qiang In usbredir destroy dispatch function, it doesn't free the vm change state handler once registered in usbredir_realize function. This will lead a memory leak issue. This patch avoid this. Signed-off-by: Li Qiang Reviewed-by: Marc-Andr=C3=A9 Lureau Message-id: 58216976.d0236b0a.77b99.bcd6@mx.google.com Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 528081e..a657237 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -132,6 +132,7 @@ struct USBRedirDevice { struct usbredirfilter_rule *filter_rules; int filter_rules_count; int compatible_speedmask; + VMChangeStateEntry *vmstate; }; =20 #define TYPE_USB_REDIR "usb-redir" @@ -1411,7 +1412,8 @@ static void usbredir_realize(USBDevice *udev, Error= **errp) usbredir_chardev_read, usbredir_chardev_eve= nt, dev, NULL, true); =20 - qemu_add_vm_change_state_handler(usbredir_vm_state_change, dev); + dev->vmstate =3D + qemu_add_vm_change_state_handler(usbredir_vm_state_change, dev); } =20 static void usbredir_cleanup_device_queues(USBRedirDevice *dev) @@ -1450,6 +1452,7 @@ static void usbredir_handle_destroy(USBDevice *udev= ) } =20 free(dev->filter_rules); + qemu_del_vm_change_state_handler(dev->vmstate); } =20 static int usbredir_check_filter(USBRedirDevice *dev) --=20 1.8.3.1