From: yuri.benditovich@daynix.com
To: "Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org
Cc: dmitry@daynix.com, yan@daynix.com
Subject: [Qemu-devel] [PATCH v2 0/3] virtio-net discards TX data after link down
Date: Wed, 9 Nov 2016 17:21:59 +0200 [thread overview]
Message-ID: <1478704922-3400-1-git-send-email-yuri.benditovich@daynix.com> (raw)
From: Yuri Benditovich <yuri.benditovich@daynix.com>
https://bugzilla.redhat.com/show_bug.cgi?id=1295637
Upon set_link monitor command or upon netdev deletion
virtio-net sends link down indication to the guest
and stops vhost if one is used.
Guest driver can still submit data for TX until it
recognizes link loss. If these packets not returned by
the host, the Windows guest will never be able to finish
disable/removal/shutdown. In order to allow qemu to
discard these packets, virtio queue shall update
its internal structure upon vhost stop.
Changes from v1:
- added drop for outstanding tx packets for tx=timer
- (mainly for case of vhost=off)
fixed link down flow to drop outstanding packets and
ensure tx queue notification enabled
Yuri Benditovich (3):
net: Add virtio queue interface to update used index from vring state
net: vhost stop updates virtio queue state
net: virtio-net discards TX data after link down
hw/net/virtio-net.c | 28 ++++++++++++++++++++++++++++
hw/virtio/vhost.c | 1 +
hw/virtio/virtio.c | 5 +++++
include/hw/virtio/virtio.h | 1 +
4 files changed, 35 insertions(+)
--
1.9.1
next reply other threads:[~2016-11-09 15:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 15:21 yuri.benditovich [this message]
2016-11-09 15:22 ` [Qemu-devel] [PATCH v2 1/3] net: Add virtio queue interface to update used index from vring state yuri.benditovich
2016-11-09 15:22 ` [Qemu-devel] [PATCH v2 2/3] net: vhost stop updates virtio queue state yuri.benditovich
2016-11-09 17:07 ` Paolo Bonzini
2016-11-09 20:12 ` Michael S. Tsirkin
2016-11-09 15:22 ` [Qemu-devel] [PATCH v2 3/3] net: virtio-net discards TX data after link down yuri.benditovich
2016-11-09 20:28 ` Michael S. Tsirkin
2016-11-09 23:56 ` Yuri Benditovich
2016-11-10 13:54 ` Michael S. Tsirkin
2016-11-10 20:56 ` Yuri Benditovich
2016-11-23 9:52 ` Yuri Benditovich
2016-11-23 13:16 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478704922-3400-1-git-send-email-yuri.benditovich@daynix.com \
--to=yuri.benditovich@daynix.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).