From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4XS6-0006Ew-90 for qemu-devel@nongnu.org; Wed, 09 Nov 2016 13:18:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4XS2-0004SQ-GA for qemu-devel@nongnu.org; Wed, 09 Nov 2016 13:18:26 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:35604 helo=relay.sw.ru) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4XS2-0004Rm-3W for qemu-devel@nongnu.org; Wed, 09 Nov 2016 13:18:22 -0500 From: Vladimir Sementsov-Ogievskiy Date: Wed, 9 Nov 2016 21:17:49 +0300 Message-Id: <1478715476-132280-15-git-send-email-vsementsov@virtuozzo.com> In-Reply-To: <1478715476-132280-1-git-send-email-vsementsov@virtuozzo.com> References: <1478715476-132280-1-git-send-email-vsementsov@virtuozzo.com> Subject: [Qemu-devel] [PATCH 14/21] block: add bdrv_can_store_dirty_bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, armbru@redhat.com, eblake@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, vsementsov@virtuozzo.com, pbonzini@redhat.com This will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch) Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 22 ++++++++++++++++++++++ include/block/block.h | 2 ++ include/block/block_int.h | 2 ++ 3 files changed, 26 insertions(+) diff --git a/block.c b/block.c index 2429384..1570b15 100644 --- a/block.c +++ b/block.c @@ -4136,3 +4136,25 @@ void bdrv_store_persistent_dirty_bitmaps(BlockDriverState *bs, Error **errp) drv->bdrv_store_persistent_dirty_bitmaps(bs, errp); } + +bool bdrv_can_store_dirty_bitmap(BlockDriverState *bs, const char *name, + uint32_t granularity, Error **errp) +{ + BlockDriver *drv = bs->drv; + + if (!drv) { + error_setg_errno(errp, ENOMEDIUM, + "Can't store persistent bitmaps to %s", + bdrv_get_device_or_node_name(bs)); + return false; + } + + if (!drv->bdrv_can_store_dirty_bitmap) { + error_setg_errno(errp, ENOTSUP, + "Can't store persistent bitmaps to %s", + bdrv_get_device_or_node_name(bs)); + return false; + } + + return drv->bdrv_can_store_dirty_bitmap(bs, name, granularity, errp); +} diff --git a/include/block/block.h b/include/block/block.h index d23133b..6084fb7 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -526,5 +526,7 @@ void bdrv_del_child(BlockDriverState *parent, BdrvChild *child, Error **errp); void bdrv_load_autoloading_dirty_bitmaps(BlockDriverState *bs, Error **errp); void bdrv_store_persistent_dirty_bitmaps(BlockDriverState *bs, Error **errp); +bool bdrv_can_store_dirty_bitmap(BlockDriverState *bs, const char *name, + uint32_t granularity, Error **errp); #endif diff --git a/include/block/block_int.h b/include/block/block_int.h index 1adb699..f263b7e 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -326,6 +326,8 @@ struct BlockDriver { Error **errp); void (*bdrv_store_persistent_dirty_bitmaps)(BlockDriverState *bs, Error **errp); + bool (*bdrv_can_store_dirty_bitmap)(BlockDriverState *bs, const char *name, + uint32_t granularity, Error **errp); QLIST_ENTRY(BlockDriver) list; }; -- 1.8.3.1