From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4tWt-0004tx-5p for qemu-devel@nongnu.org; Thu, 10 Nov 2016 12:52:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4tWq-0003LJ-H3 for qemu-devel@nongnu.org; Thu, 10 Nov 2016 12:52:51 -0500 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34509) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4tWq-0003L1-9k for qemu-devel@nongnu.org; Thu, 10 Nov 2016 12:52:48 -0500 Received: by mail-wm0-x244.google.com with SMTP id g23so4619036wme.1 for ; Thu, 10 Nov 2016 09:52:48 -0800 (PST) Received: from 640k.lan (94-39-185-129.adsl-ull.clienti.tiscali.it. [94.39.185.129]) by smtp.gmail.com with ESMTPSA id ia7sm6688769wjb.23.2016.11.10.09.52.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Nov 2016 09:52:45 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 10 Nov 2016 18:52:37 +0100 Message-Id: <1478800362-18138-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1478800362-18138-1-git-send-email-pbonzini@redhat.com> References: <1478800362-18138-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 1/6] target-i386: fix typo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The impact is small because kvm_get_vcpu_events fixes env->hflags, but it is wrong and could cause INITs to be delayed arbitrarily with -machine kernel_irqchip=off. Reported-by: Achille Fouilleul Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target-i386/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 1c0864e..f62264a 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -2855,7 +2855,7 @@ MemTxAttrs kvm_arch_post_run(CPUState *cpu, struct kvm_run *run) if (run->flags & KVM_RUN_X86_SMM) { env->hflags |= HF_SMM_MASK; } else { - env->hflags &= HF_SMM_MASK; + env->hflags &= ~HF_SMM_MASK; } if (run->if_flag) { env->eflags |= IF_MASK; -- 1.8.3.1