From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4tWw-0004xY-2x for qemu-devel@nongnu.org; Thu, 10 Nov 2016 12:52:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4tWv-0003Nl-G2 for qemu-devel@nongnu.org; Thu, 10 Nov 2016 12:52:54 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34516) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4tWv-0003NJ-9n for qemu-devel@nongnu.org; Thu, 10 Nov 2016 12:52:53 -0500 Received: by mail-wm0-x242.google.com with SMTP id g23so4619343wme.1 for ; Thu, 10 Nov 2016 09:52:53 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 10 Nov 2016 18:52:41 +0100 Message-Id: <1478800362-18138-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1478800362-18138-1-git-send-email-pbonzini@redhat.com> References: <1478800362-18138-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 5/6] target-i386: document how x86 gdb_num_core_regs is computed. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Doug Evans From: Doug Evans It helps when reading the code to see how the number is arrived at. Signed-off-by: Doug Evans Message-Id: <94eb2c187eda43dba005406c86f7@google.com> Signed-off-by: Paolo Bonzini --- target-i386/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 14c5186..6eec5dc 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -3721,6 +3721,9 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data) cc->write_elf32_qemunote = x86_cpu_write_elf32_qemunote; cc->vmsd = &vmstate_x86_cpu; #endif + /* CPU_NB_REGS * 2 = general regs + xmm regs + * 25 = eip, eflags, 6 seg regs, st[0-7], fctrl,...,fop, mxcsr. + */ cc->gdb_num_core_regs = CPU_NB_REGS * 2 + 25; #ifndef CONFIG_USER_ONLY cc->debug_excp_handler = breakpoint_handler; -- 1.8.3.1