Re: [Qemu-devel] [PATCH v2 0/1] vfio-pci: fix assert fail in host property if unused

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v2 0/1] vfio-pci: fix assert fail in host property if unused
Message-id: cover.1478777270.git.daniel.oram@gmail.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
1aec960 Fix assert in PCI address property when used by vfio-pci

=== OUTPUT BEGIN ===
fatal: unrecognized argument: --no-patch
Checking PATCH 1/1: ...
ERROR: trailing whitespace
#34: FILE: hw/core/qdev-properties.c:711:
+    $

ERROR: trailing whitespace
#36: FILE: hw/core/qdev-properties.c:713:
+     * Catch "invalid" device reference from vfio-pci and allow the $

ERROR: trailing whitespace
#40: FILE: hw/core/qdev-properties.c:717:
+           $

ERROR: trailing whitespace
#45: FILE: hw/core/qdev-properties.c:722:
+    $

total: 4 errors, 0 warnings, 26 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org