From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>,
Igor Mammedov <imammedo@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL v3 23/28] nvdimm acpi: use aml_name_decl to define named object
Date: Tue, 15 Nov 2016 21:22:19 +0200 [thread overview]
Message-ID: <1479237527-11846-24-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1479237527-11846-1-git-send-email-mst@redhat.com>
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
to make the code more clearer
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
hw/acpi/nvdimm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 6692648..5f48b75 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -1098,13 +1098,11 @@ static void nvdimm_build_fit(Aml *dev)
buf_size = aml_local(1);
fit = aml_local(2);
- aml_append(dev, aml_create_dword_field(aml_buffer(4, NULL),
- aml_int(0), NVDIMM_DSM_RFIT_STATUS));
+ aml_append(dev, aml_name_decl(NVDIMM_DSM_RFIT_STATUS, aml_int(0)));
/* build helper function, RFIT. */
method = aml_method("RFIT", 1, AML_SERIALIZED);
- aml_append(method, aml_create_dword_field(aml_buffer(4, NULL),
- aml_int(0), "OFST"));
+ aml_append(method, aml_name_decl("OFST", aml_int(0)));
/* prepare input package. */
pkg = aml_package(1);
--
MST
next prev parent reply other threads:[~2016-11-15 19:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 19:20 [Qemu-devel] [PULL v3 00/28] virtio, vhost, pc, pci: documentation, fixes and cleanups Michael S. Tsirkin
2016-11-15 19:20 ` [Qemu-devel] [PULL v3 01/28] intel_iommu: fixing source id during IOTLB hash key calculation Michael S. Tsirkin
2016-11-15 19:20 ` [Qemu-devel] [PULL v3 02/28] virtio: rename virtqueue_discard to virtqueue_unpop Michael S. Tsirkin
2016-11-15 19:20 ` [Qemu-devel] [PULL v3 03/28] virtio: make virtqueue_alloc_element static Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 04/28] virtio-crypto: tag as not hotpluggable and migration Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 05/28] intel_iommu: fix several incorrect endianess and bit fields Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 06/28] intel_iommu: fix incorrect assert Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 07/28] acpi: fix DMAR device scope for IOAPIC Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 08/28] virtio: allow per-device-class legacy features Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 09/28] virtio-net: mark VIRTIO_NET_F_GSO as legacy Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 10/28] vhost: migration blocker only if shared log is used Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 11/28] qdev: hotplug: drop HotplugHandler.post_plug callback Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 12/28] nvdimm acpi: drop the lock of fit buffer Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 13/28] pc: memhp: move nvdimm hotplug out of memory hotplug Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 14/28] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 15/28] nvdimm acpi: clean up nvdimm_build_acpi Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 16/28] docs: improve the doc of Read FIT method Michael S. Tsirkin
2016-11-15 19:21 ` [Qemu-devel] [PULL v3 17/28] nvdimm acpi: rename nvdimm_plugged_device_list Michael S. Tsirkin
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 18/28] nvdimm acpi: cleanup nvdimm_build_fit Michael S. Tsirkin
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 19/28] nvdimm acpi: rename nvdimm_acpi_hotplug Michael S. Tsirkin
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 20/28] nvdimm acpi: define DSM return codes Michael S. Tsirkin
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 21/28] nvdimm acpi: fix two comments Michael S. Tsirkin
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 22/28] nvdimm acpi: rename nvdimm_dsm_reserved_root Michael S. Tsirkin
2016-11-15 19:22 ` Michael S. Tsirkin [this message]
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 24/28] nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE Michael S. Tsirkin
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 25/28] vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout Michael S. Tsirkin
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 26/28] vhost: drop legacy vring layout bits Michael S. Tsirkin
2016-11-15 20:35 ` Greg Kurz
2016-11-15 22:00 ` Michael S. Tsirkin
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 27/28] virtio: drop virtio_queue_get_ring_{size, addr}() Michael S. Tsirkin
2016-11-15 19:22 ` [Qemu-devel] [PULL v3 28/28] docs: add PCIe devices placement guidelines Michael S. Tsirkin
2016-11-15 19:51 ` [Qemu-devel] [PULL v3 00/28] virtio, vhost, pc, pci: documentation, fixes and cleanups Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479237527-11846-24-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).