qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH for-2.9 0/2] qom, qdev: Cleanup release functions
Date: Wed, 16 Nov 2016 16:57:42 -0200	[thread overview]
Message-ID: <1479322664-2253-1-git-send-email-ehabkost@redhat.com> (raw)

While working on the qdev class properteis series, I've noticed
that the release function for class properties is never called,
and have unclear semantics (should it be called when the object
is destroyed, or when the class is destroyed?). Patch 1/1 removes
the unused feature.

Patch 2/2 changes the function signature of qdev property release
functions to make their implementations simpler and safer, and
make them not depend on the way property release functions are
implemented (so the functions don't need to be rewritten if we
change qdev to use class properties).

Eduardo Habkost (2):
  qom: Remove release function from class properties
  qdev: Change signature of PropertyInfo::release

 backends/hostmem.c               |  4 ++--
 hw/core/machine.c                |  6 +++---
 hw/core/qdev-properties-system.c |  8 ++------
 hw/core/qdev-properties.c        | 10 +++++-----
 hw/core/qdev.c                   | 10 +++++++++-
 hw/i386/pc.c                     |  8 ++++----
 hw/ppc/pnv.c                     |  2 +-
 include/hw/qdev-core.h           |  2 +-
 include/qom/object.h             |  1 -
 qom/object.c                     | 14 ++++----------
 10 files changed, 31 insertions(+), 34 deletions(-)

-- 
2.7.4

             reply	other threads:[~2016-11-16 18:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 18:57 Eduardo Habkost [this message]
2016-11-16 18:57 ` [Qemu-devel] [PATCH for-2.9 1/2] qom: Remove release function from class properties Eduardo Habkost
2016-11-17 12:33   ` Markus Armbruster
2016-11-17 13:36     ` Eduardo Habkost
2016-11-17 14:45       ` Markus Armbruster
2016-11-16 18:57 ` [Qemu-devel] [PATCH for-2.9 2/2] qdev: Change signature of PropertyInfo::release Eduardo Habkost
2016-11-17 12:26   ` Markus Armbruster
2016-11-17 13:40     ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479322664-2253-1-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).