From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c788r-0003Uo-IZ for qemu-devel@nongnu.org; Wed, 16 Nov 2016 16:53:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c788o-0006Qd-I5 for qemu-devel@nongnu.org; Wed, 16 Nov 2016 16:53:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51810) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c788o-0006QG-C3 for qemu-devel@nongnu.org; Wed, 16 Nov 2016 16:53:14 -0500 From: Stefan Hajnoczi Date: Wed, 16 Nov 2016 21:53:07 +0000 Message-Id: <1479333189-20082-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1479333189-20082-1-git-send-email-stefanha@redhat.com> References: <1479333189-20082-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] virtio: add missing vdev->broken check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: zhunxun@gmail.com, Fam Zheng , Christian Borntraeger , Paolo Bonzini , "Michael S. Tsirkin" , Kevin Wolf , Stefan Hajnoczi virtio_queue_notify_vq() checks vdev->broken before invoking the handler, virtio_queue_notify_aio_vq() should too. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 55a00cd..a4759bd 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -1239,6 +1239,10 @@ static void virtio_queue_notify_aio_vq(VirtQueue *vq) if (vq->vring.desc && vq->handle_aio_output) { VirtIODevice *vdev = vq->vdev; + if (unlikely(vq->vdev->broken)) { + return; + } + trace_virtio_queue_notify(vdev, vq - vdev->vq, vq); vq->handle_aio_output(vdev, vq); } -- 2.7.4