From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7kfa-0005uH-Bc for qemu-devel@nongnu.org; Fri, 18 Nov 2016 10:01:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7kfW-00045x-Rg for qemu-devel@nongnu.org; Fri, 18 Nov 2016 10:01:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51188) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7kfW-00045G-Lg for qemu-devel@nongnu.org; Fri, 18 Nov 2016 10:01:34 -0500 From: Stefan Hajnoczi Date: Fri, 18 Nov 2016 15:01:29 +0000 Message-Id: <1479481289-2479-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1479481289-2479-1-git-send-email-stefanha@redhat.com> References: <1479481289-2479-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 1/1] trace: fix generated code build break List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Greg Kurz , Stefan Hajnoczi From: Greg Kurz If the QEMU source dir is /var/tmp/aaa-qemu-clone and the build dir is /var/tmp/qemu-aio-poll-v2 Then I get an error as: trace/generated-tracers.c:15950:13: error: invalid suffix "_trace_events" on integer constant TraceEvent *2_trace_events[] =3D { ^ trace/generated-tracers.c:15950:13: error: expected identifier or =E2=80=98= (=E2=80=99 before numeric constant trace/generated-tracers.c: In function =E2=80=98trace_2_register_events=E2= =80=99: trace/generated-tracers.c:17949:32: error: invalid suffix "_trace_events"= on integer constant trace_event_register_group(2_trace_events); ^ make: *** [trace/generated-tracers.o] Error 1 This patch fixes the issue. Reported-by: Fam Zheng Signed-off-by: Greg Kurz Tested-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- scripts/tracetool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index fe9c9e9..c9e4737 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -70,7 +70,7 @@ def make_group_name(filename): =20 if dirname =3D=3D "": return "common" - return re.sub(r"[^A-Za-z0-9]", "_", dirname) + return "_" + re.sub(r"[^A-Za-z0-9]", "_", dirname) =20 def main(args): global _SCRIPT --=20 2.7.4