From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzg4g-0004n8-6v for qemu-devel@nongnu.org; Tue, 02 Jun 2015 02:53:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzg4d-0005ZV-02 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 02:53:22 -0400 Received: from nm6-vm10.bullet.mail.sg3.yahoo.com ([106.10.148.169]:49296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzg4c-0005Z3-2i for qemu-devel@nongnu.org; Tue, 02 Jun 2015 02:53:18 -0400 Date: Tue, 2 Jun 2015 06:51:30 +0000 (UTC) From: P J P Message-ID: <1479491695.1864821.1433227890796.JavaMail.yahoo@mail.yahoo.com> In-Reply-To: <87iob7lv1p.fsf@blackfin.pond.sub.org> References: <87iob7lv1p.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net: fix insecure temporary file creation in SLiRP Reply-To: P J P List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , "mrezanin@redhat.com" Cc: Michael Tokarev , "pmatouse@redhat.com" , "qemu-devel@nongnu.org" Hello Markus, > On Monday, 1 June 2015 1:28 PM, Markus Armbruster wrote: > Michael (cc'ed) already posted "[PATCH] slirp: use less predictable > directory name in /tmp for smb config (CVE-2015-4037)"[*]. His patch > clobbers s->smb_dir[] when mkdtemp() fails (missed that in my review), > yours doesn't. > > Suggest you guys figure out together which solution you want. Thank you so much for the review. IMO using separate smb_dir[] is prudent than s->smb_dir. > Preferably with strncpy() replaced by pstrcpy(): Yes. Thank you. --- Regards -P J P http://feedmug.com