From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7rjc-0000As-LV for qemu-devel@nongnu.org; Fri, 18 Nov 2016 17:34:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7rjX-00083p-PC for qemu-devel@nongnu.org; Fri, 18 Nov 2016 17:34:16 -0500 Received: from smtp5-g21.free.fr ([212.27.42.5]:4999) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7rjX-000817-HU for qemu-devel@nongnu.org; Fri, 18 Nov 2016 17:34:11 -0500 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Fri, 18 Nov 2016 23:33:17 +0100 Message-Id: <1479508397-8443-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH for-2.8] scsi/esp: do not raise an interrupt when reading the FIFO register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Prasad J Pandit , =?UTF-8?q?Herv=C3=A9=20Poussineau?= This fixes SCSI adapter self-tests done in MIPS Jazz emulation, broken since ff589551c8e8e9e95e211b9d8daafb4ed39f1aec. Signed-off-by: Herv=C3=A9 Poussineau --- hw/scsi/esp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 1f2f2d3..5a5a4e9 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -406,11 +406,9 @@ uint64_t esp_reg_read(ESPState *s, uint32_t saddr) /* Data out. */ qemu_log_mask(LOG_UNIMP, "esp: PIO data read not implemented= \n"); s->rregs[ESP_FIFO] =3D 0; - esp_raise_irq(s); } else if (s->ti_rptr < s->ti_wptr) { s->ti_size--; s->rregs[ESP_FIFO] =3D s->ti_buf[s->ti_rptr++]; - esp_raise_irq(s); } if (s->ti_rptr =3D=3D s->ti_wptr) { s->ti_rptr =3D 0; --=20 2.1.4