From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8sRW-0001iW-8W for qemu-devel@nongnu.org; Mon, 21 Nov 2016 12:31:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8sRV-0008Fn-Ds for qemu-devel@nongnu.org; Mon, 21 Nov 2016 12:31:46 -0500 From: Kevin Wolf Date: Mon, 21 Nov 2016 18:31:22 +0100 Message-Id: <1479749488-31808-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1479749488-31808-1-git-send-email-kwolf@redhat.com> References: <1479749488-31808-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, eblake@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org There is no point in passing the value of bs->opaque in order to overwrite it with itself. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Paolo Bonzini Reviewed-by: Alberto Garcia --- block/quorum.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index d122299..dfa9fd3 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -171,18 +171,17 @@ static bool quorum_64bits_compare(QuorumVoteValue *a, QuorumVoteValue *b) return a->l == b->l; } -static QuorumAIOCB *quorum_aio_get(BDRVQuorumState *s, - BlockDriverState *bs, +static QuorumAIOCB *quorum_aio_get(BlockDriverState *bs, QEMUIOVector *qiov, uint64_t sector_num, int nb_sectors, BlockCompletionFunc *cb, void *opaque) { + BDRVQuorumState *s = bs->opaque; QuorumAIOCB *acb = qemu_aio_get(&quorum_aiocb_info, bs, cb, opaque); int i; - acb->common.bs->opaque = s; acb->sector_num = sector_num; acb->nb_sectors = nb_sectors; acb->qiov = qiov; @@ -691,7 +690,7 @@ static BlockAIOCB *quorum_aio_readv(BlockDriverState *bs, void *opaque) { BDRVQuorumState *s = bs->opaque; - QuorumAIOCB *acb = quorum_aio_get(s, bs, qiov, sector_num, + QuorumAIOCB *acb = quorum_aio_get(bs, qiov, sector_num, nb_sectors, cb, opaque); acb->is_read = true; acb->children_read = 0; @@ -711,7 +710,7 @@ static BlockAIOCB *quorum_aio_writev(BlockDriverState *bs, void *opaque) { BDRVQuorumState *s = bs->opaque; - QuorumAIOCB *acb = quorum_aio_get(s, bs, qiov, sector_num, nb_sectors, + QuorumAIOCB *acb = quorum_aio_get(bs, qiov, sector_num, nb_sectors, cb, opaque); int i; -- 1.8.3.1