From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: BALATON Zoltan <balaton@eik.bme.hu>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle
Date: Tue, 22 Nov 2016 13:50:04 +1100 [thread overview]
Message-ID: <1479783004.10230.57.camel@kernel.crashing.org> (raw)
In-Reply-To: <alpine.BSF.2.20.1611220222090.35319@zero.eik.bme.hu>
On Tue, 2016-11-22 at 02:34 +0100, BALATON Zoltan wrote:
> > Is this going in for 2.8? If so, I'll need to apply the corresponding
> > patch to OpenBIOS to match and also do a PPC testing cycle to make sure
> > that there are no regressions on other OSs. Plus it would be useful to
> > get both pull requests in close proximity as this will break bisection.
>
> (Adding BenH as these are his patches I just apparently forgot the cc.)
>
> I'd appreciate if this could get in 2.8. As this is a bugfix this should
> be OK during the freeze. Likely there will be more rc cycles where it
> could be reverted if found to cause problems. But since it's already
> broken, applying this patch to QEMU should not break it more and adding
> the fix on the OpenBIOS side (patch 4/4) would complete the fix and may
> actually make it work. This should only affect mac99 and this one patch is
> independent from the other three I've sent to OpenBIOS so this could be
> applied independently to get at least the interrupts fixed if you can't
> test and apply the other three until the next pull.
Right, PCI IRQs are terminally broken already. This patch without the
OpenBIOS change won't hurt. With the OpenBIOS change, things start
working better :-)
I appologize for being basically MIA these days, way too busy with
other things. Feel free to pick up ownership of my patches if you
want to get them into upstreamable state, such as the SunGEM one.
I don't know if I'll have any bandwidth to work on that stuff again
until later next year.
Cheers,
Ben.
next prev parent reply other threads:[~2016-11-22 2:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 14:12 [Qemu-devel] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle BALATON Zoltan
2016-11-21 10:06 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2016-11-21 23:05 ` David Gibson
2016-11-22 0:12 ` Mark Cave-Ayland
2016-11-22 1:34 ` BALATON Zoltan
2016-11-22 2:50 ` Benjamin Herrenschmidt [this message]
[not found] <mailman.20732.1479800734.22740.qemu-devel@nongnu.org>
2016-11-22 14:49 ` G 3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479783004.10230.57.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).