From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c91AP-00040u-3r for qemu-devel@nongnu.org; Mon, 21 Nov 2016 21:50:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c91AL-0005jB-4X for qemu-devel@nongnu.org; Mon, 21 Nov 2016 21:50:41 -0500 Message-ID: <1479783004.10230.57.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Tue, 22 Nov 2016 13:50:04 +1100 In-Reply-To: References: <20161120231605.D90DD745789@zero.eik.bme.hu> <20161121230529.GC8681@umbus.fritz.box> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan , Mark Cave-Ayland Cc: David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Tue, 2016-11-22 at 02:34 +0100, BALATON Zoltan wrote: > > Is this going in for 2.8? If so, I'll need to apply the corresponding > > patch to OpenBIOS to match and also do a PPC testing cycle to make su= re > > that there are no regressions on other OSs. Plus it would be useful t= o > > get both pull requests in close proximity as this will break bisectio= n. >=20 > (Adding BenH as these are his patches I just apparently forgot the cc.) >=20 > I'd appreciate if this could get in 2.8. As this is a bugfix this shoul= d=C2=A0 > be OK during the freeze. Likely there will be more rc cycles where it=C2= =A0 > could be reverted if found to cause problems. But since it's already=C2= =A0 > broken, applying this patch to QEMU should not break it more and adding= =C2=A0 > the fix on the OpenBIOS side (patch 4/4) would complete the fix and may > actually make it work. This should only affect mac99 and this one patch= is=C2=A0 > independent from the other three I've sent to OpenBIOS so this could be= =C2=A0 > applied independently to get at least the interrupts fixed=C2=A0 if you= can't=C2=A0 > test and apply the other three until the next pull. Right, PCI IRQs are terminally broken already. This patch without the OpenBIOS change won't hurt. With the OpenBIOS change, things start working better :-) I appologize for being basically MIA these days, way too busy with other things. Feel free to pick up ownership of my patches if you want to get them into upstreamable state, such as the SunGEM one. I don't know if I'll have any bandwidth to work on that stuff again until later next year. Cheers, Ben.